WAL-1381: Expand error message of TransactionSubmitFailedException (#127

)
stellar · Mar 13, 2024 · 5d2b710 · 5d2b710
1 parent 50b9c34
commit 5d2b710
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -12,7 +12,7 @@ val jvmVersion = JavaVersion.VERSION_11
 
 allprojects {
   group = "org.stellar.wallet-sdk"
-  version = "1.2.2"
+  version = "1.3.0"
 }
 
 subprojects {

diff --git a/wallet-sdk/src/main/kotlin/org/stellar/walletsdk/auth/Sep10.kt b/wallet-sdk/src/main/kotlin/org/stellar/walletsdk/auth/Sep10.kt
@@ -4,6 +4,8 @@ import io.ktor.client.*
 import io.ktor.client.call.*
 import io.ktor.client.request.*
 import io.ktor.http.*
+import java.math.BigInteger
+import java.util.*
 import kotlinx.datetime.Clock
 import mu.KotlinLogging
 import org.stellar.sdk.Network
@@ -13,8 +15,6 @@ import org.stellar.walletsdk.exception.*
 import org.stellar.walletsdk.horizon.AccountKeyPair
 import org.stellar.walletsdk.util.Util.authGet
 import org.stellar.walletsdk.util.Util.postJson
-import java.math.BigInteger
-import java.util.*
 
 private val log = KotlinLogging.logger {}
 

diff --git a/wallet-sdk/src/main/kotlin/org/stellar/walletsdk/exception/StellarExceptions.kt b/wallet-sdk/src/main/kotlin/org/stellar/walletsdk/exception/StellarExceptions.kt
@@ -1,10 +1,12 @@
 package org.stellar.walletsdk.exception
 
 import java.math.BigDecimal
+import org.stellar.sdk.AbstractTransaction
 import org.stellar.sdk.responses.SubmitTransactionResponse
 
 sealed class StellarException : WalletException {
   constructor(message: String) : super(message)
+
   constructor(message: String, cause: Exception) : super(message, cause)
 }
 
@@ -20,10 +22,12 @@ class AccountNotEnoughBalanceException(
 
 class TransactionSubmitFailedException(
   val response: SubmitTransactionResponse,
+  val transaction: AbstractTransaction
 ) :
   StellarException(
     "Submit transaction failed with code ${response.resultCode ?: "<unknown>"}" +
-      ".${response.operationsResultCodes ?. run { " Operation result codes: $this" } ?: ""}"
+      ".${response.operationsResultCodes ?. run { " Operation result codes: $this" } ?: ""}" +
+      " Transaction XDR: ${transaction.toEnvelopeXdrBase64()}"
   ) {
   val transactionResultCode = response.resultCode
   val operationsResultCodes = response.operationsResultCodes

diff --git a/wallet-sdk/src/main/kotlin/org/stellar/walletsdk/horizon/Stellar.kt b/wallet-sdk/src/main/kotlin/org/stellar/walletsdk/horizon/Stellar.kt
@@ -117,7 +117,7 @@ internal constructor(
           val response = server.submitTransaction(signedTransaction)
 
           if (!response.isSuccess) {
-            throw TransactionSubmitFailedException(response)
+            throw TransactionSubmitFailedException(response, signedTransaction)
           }
 
           log.debug { "Transaction submitted with hash ${response.hash}" }
@@ -131,7 +131,7 @@ internal constructor(
           val response = server.submitTransaction(signedTransaction)
 
           if (!response.isSuccess) {
-            throw TransactionSubmitFailedException(response)
+            throw TransactionSubmitFailedException(response, signedTransaction)
           }
 
           log.debug { "Transaction submitted with hash ${response.hash}" }