Skip to content

Commit

Permalink
Bump bcastle to 1.79, add bcutil.
Browse files Browse the repository at this point in the history
  • Loading branch information
overcat committed Nov 13, 2024
1 parent 0dd3240 commit 42b7acb
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
5 changes: 4 additions & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
[versions]
# Library versions
bcastle = "1.77"
bcastle = "1.79"
bcutil = "1.79"
coroutines = "1.6.4"
google-gson = "2.8.9"
hoplite = "2.7.0"
Expand All @@ -23,6 +24,8 @@ detekt = "1.22.0"

[libraries]
bcastle = { module = "org.bouncycastle:bcprov-jdk18on", version.ref = "bcastle" }
# EdECObjectIdentifiers is an internal class in bcastle, so we need to import bcutil.
bcutil = { module = "org.bouncycastle:bcutil-jdk18on", version.ref = "bcutil" }
coroutines-core = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-core", version.ref = "coroutines" }
coroutines-test = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-test", version.ref = "coroutines" }
google-gson = { module = "com.google.code.gson:gson", version.ref = "google-gson" }
Expand Down
9 changes: 2 additions & 7 deletions wallet-sdk/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,7 @@ configurations {

dependencies {
api(libs.coroutines.core)
api(libs.java.stellar.sdk) {
// The Java SDK uses version bcprov-jdk18on 1.78.1, but I think there are some issues with this version,
// so we had to exclude this dependency; the problem also appears in 1.79.
// https://github.com/bcgit/bc-java/issues/1621
// Maybe I should downgrade the version to 1.77 in the final release.
exclude(group = "org.bouncycastle", module = "bcprov-jdk18on")
}
api(libs.java.stellar.sdk)
api(libs.kotlin.datetime)
api(libs.bundles.ktor.client)
implementation(libs.kotlin.serialization.json)
Expand All @@ -43,6 +37,7 @@ dependencies {
implementation(libs.toml4j)
implementation(libs.jjwt)
implementation(libs.bcastle)
implementation(libs.bcutil)

testImplementation(libs.coroutines.test)
testImplementation(libs.kotlin.junit)
Expand Down

0 comments on commit 42b7acb

Please sign in to comment.