You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Right now, the test/e2e/wasms directory has built binary files copy-pasted from stellar-cli.
Describe the solution you'd like
Let's use a script with soroban contract init to copy in contracts from soroban-examples, then build those. We will need to use off-the-shelf soroban-examples, though, which means we will need to modify some of these tests. The test-wasms directory in stellar-cli contains somewhat-modified examples contracts, such as a hello_world contract with increment behavior. We will need to change the tests that expect this to instead test the two separate contracts. (Or, honestly, if you look over the tests and decide we don't need both, then we can remove some tests.)
Describe alternatives you've considered
We could add soroban-examples as a git submodule.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
Right now, the
test/e2e/wasms
directory has built binary files copy-pasted fromstellar-cli
.Describe the solution you'd like
Let's use a script with
soroban contract init
to copy in contracts fromsoroban-examples
, then build those. We will need to use off-the-shelf soroban-examples, though, which means we will need to modify some of these tests. Thetest-wasms
directory in stellar-cli contains somewhat-modified examples contracts, such as ahello_world
contract with increment behavior. We will need to change the tests that expect this to instead test the two separate contracts. (Or, honestly, if you look over the tests and decide we don't need both, then we can remove some tests.)Describe alternatives you've considered
We could add
soroban-examples
as a git submodule.The text was updated successfully, but these errors were encountered: