Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use soroban contract init to generate contracts for e2e tests #980

Open
chadoh opened this issue Jun 4, 2024 · 1 comment · Fixed by #995 or stellar/soroban-examples#313
Open

Comments

@chadoh
Copy link
Contributor

chadoh commented Jun 4, 2024

Is your feature request related to a problem? Please describe.
Right now, the test/e2e/wasms directory has built binary files copy-pasted from stellar-cli.

Describe the solution you'd like
Let's use a script with soroban contract init to copy in contracts from soroban-examples, then build those. We will need to use off-the-shelf soroban-examples, though, which means we will need to modify some of these tests. The test-wasms directory in stellar-cli contains somewhat-modified examples contracts, such as a hello_world contract with increment behavior. We will need to change the tests that expect this to instead test the two separate contracts. (Or, honestly, if you look over the tests and decide we don't need both, then we can remove some tests.)

Describe alternatives you've considered
We could add soroban-examples as a git submodule.

@chadoh chadoh added this to Aha Jun 4, 2024
@chadoh chadoh moved this to To do in Aha Jun 4, 2024
@BlaineHeffron BlaineHeffron moved this from To do to In Progress in Aha Jun 18, 2024
@BlaineHeffron
Copy link
Contributor

#995

@BlaineHeffron BlaineHeffron moved this from In Progress to Done in Aha Jul 13, 2024
@BlaineHeffron BlaineHeffron moved this from Done to In Progress in Aha Jul 13, 2024
@BlaineHeffron BlaineHeffron moved this from In Progress to Done in Aha Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants