Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/use init e2e #995

Merged
merged 8 commits into from
Jul 16, 2024
Merged

Chore/use init e2e #995

merged 8 commits into from
Jul 16, 2024

Conversation

BlaineHeffron
Copy link
Contributor

@BlaineHeffron BlaineHeffron commented Jun 20, 2024

This changes the e2e tests to use soroban contract init instead of using pre-built wasms. Needs stellar/soroban-examples#313 to be merged for it to work.

Close #980

test/e2e/src/util.js Fixed Show fixed Hide fixed
test/e2e/src/util.js Fixed Show fixed Hide fixed
test/e2e/src/util.js Fixed Show fixed Hide fixed
@BlaineHeffron BlaineHeffron marked this pull request as ready for review June 27, 2024 21:09
Copy link
Contributor

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one Q below ⬇️

test/e2e/initialize.sh Outdated Show resolved Hide resolved
@BlaineHeffron
Copy link
Contributor Author

Added a git hash check in addition to a wasm check, will rebuild if hashes are different.

@Shaptic Shaptic merged commit fa6b2e7 into stellar:master Jul 16, 2024
10 checks passed
@BlaineHeffron BlaineHeffron deleted the chore/use-init-e2e branch July 17, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Use soroban contract init to generate contracts for e2e tests
3 participants