Fixes to build libvips in December 2019 #9
Conversation
This reverts commit 2fb9e33.
9.21 was effectively hard-coded.
Using -jX in particular is known to cause build failures.
It seems this was accidentally removed in 73cb13b
Avoid the need to re-download all source tarballs on any build failure.
The 1.6.30 release source tarball no longer seems to be available for download from the official site.
The patches are no longer required, but this code has no libvips version checks.
Using -jX in particular is known to cause build failures.
All of these scripts are sourced, not executed.
This will hopefully help with build failures when running make with the -jX argument.
It was effectively hard-coded to only allow 2.52.* releases.
boltronics
force-pushed
the
dec_2019_fixes
branch
from
85a77df
to
c532cea
Compare
.gz is available for all releases, including the latest. .bz2 is not since older releases were .gz only, and newer releases (from 2.13.92 onwards) are .gz and .xz only.
|
Let me know when you are ready to merge? Also, if you are interested in taking over maintenance ... well, we haven't used it in over 1.5 years. I'm actually building libvips alongside PHP and others such that they all share the same updated libraries in a different repo. Interested? |
|
Thanks @bubba-h57 for looking at the PR request and for the maintainer offer. I'm not sure right now how much I'll be using this project going forward. It could be quite a lot, or not at all, so I might have to wait and see and get back to you. I previously thought this PR was good to merge when I initially opened it, but then as you've no doubt noticed, I found a couple more things to change. Perhaps it might be better if I confirm I'm happy with everything in the next week or so, if that's okay with you? |
|
Absolutely! |
|
@boltronics I'm trying to get your changes to build, and they do build successfully. However, when trying to confirm the installation, I'm running When unpackaging the generated tar in the |
It's been a while since this project was last updated, and many of the URLs were no longer working.
Additionally, it seems a number of bugs were introduced in recent commits, such as the seemingly accidental removal of the
xml2.shfile contents, or the command to tar up amodulesdirectory unconditionally, regardless of the PHP modules being built (and that directory existing or not).Due to needing to perform a lot of rebuilds until all issues were sorted, I found it helpful to have dependency downloads cached instead of re-fetched each time. This might also help someone if some of the downloads disappear later but another rebuild is required.
I also adjusted the MAKEFLAGS to have builds run faster, but this seemed to be incompatible with a single
make installcommand to build and install, so I separated dependency builds out into separatemakeandmake installsteps which seems to work for me.While a couple of problematic dependency versions have had a bump to a newer release, I have not checked and updated any other dependencies. I can confirm with these changes I could successfully build a working libvips 8.8.3, which is the latest version as of writing.