feat: add C implementation for `number/float32/base/signbit` #623

Planeshifter · 2022-11-15T01:22:12Z

Description

What is the purpose of this pull request?

This pull request:

adds a C implementation for @stdlib/number/float32/base/signbit

Related Issues

Does this pull request have any related issues?

This pull request:

resolves #
fixes #

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Opening this PR to test out and incrementally improve our AI workflow for scaffolding packages, which includes addition of C implementations. I expect to delete and re-run the respective scaffolding workflows multiple times as I continue improving the scaffolding outputs.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

github-actions · 2022-11-15T13:02:43Z

Based off the README.md file, the stdlib-bot has generated contents for the signbitf package and pushed them to the pull request branch.

Notes

⚠️ The stdlib-bot uses AI to generate package content. The generated content is not guaranteed to be correct, and will require manual review and editing. ⚠️

Planeshifter

@kgryte Would appreciate a look at the scaffolded files to catch any further issues that need to be resolved with our bot.

Planeshifter · 2022-11-15T13:08:54Z

lib/node_modules/@stdlib/number/float32/base/signbit/src/addon.c

+#include "stdlib/math/base/special/signbitf.h"
+#include "stdlib/math/base/napi/unary.h"
+
+STDLIB_MATH_BASE_NAPI_MODULE_D_B( stdlib_base_signbitf )


@kgryte So STDLIB_MATH_BASE_NAPI_MODULE_D_B doesn't exist in stdlib/math/base/napi/unary.h. What should this file look like?

There won't be this macro, as it is not common enough. See https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/number/float64/base/signbit/src/addon.c. Unless this pattern happens over and over, not likely to add. As mentioned elsewhere, cannot really predict what should go in addon.c as it will vary from package to package, even if for some types of packages, such as math/base/special/*, we predominantly use macros, this won't be true elsewhere (e.g., in number/base/* or blas/* or strided/*).

In short, in terms of scaffolding, I'd template the addon.c file with a TODO.

kgryte · 2022-11-15T20:35:27Z

lib/node_modules/@stdlib/number/float32/base/signbit/README.md

+
+#### stdlib_base_float32_signbit( x )
+
+Returns a `boolean` indicating if the sign bit for a [single-precision floating-point number][ieee754] is on (`true`) or off (`false`).


This is not correct. See https://github.com/stdlib-js/stdlib/tree/6e32d9591ed2e6551de73ca0ff9ea2cc8f59824d/lib/node_modules/%40stdlib/number/float64/base/signbit#stdlib_base_float64_signbit-x-.

We cannot rely on JS and C APIs being the same in terms of API signatures.

kgryte · 2022-11-15T20:37:28Z

lib/node_modules/@stdlib/number/float32/base/signbit/benchmark/c/benchmark.c

+#include <time.h>
+#include <sys/time.h>
+
+#define NAME "{{alias}}"


Missing {{alias}}.

kgryte · 2022-11-15T20:39:27Z

lib/node_modules/@stdlib/number/float32/base/signbit/benchmark/c/benchmark.c

+	double elapsed;
+	bool out;
+	float x;
+	double t;


Incorrect order.

kgryte · 2022-11-15T20:39:40Z

lib/node_modules/@stdlib/number/float32/base/signbit/benchmark/c/benchmark.c

+	t = tic();
+	for ( i = 0; i < ITERATIONS; i++ ) {
+		x = ( rand_double()*1000.0f ) - 500.0f;
+		out = x < 0.0f;


Not sure what happened here.

Personally, I'd just insert a TODO here, as benchmarks can be fairly bespoke.

kgryte · 2022-11-15T20:41:02Z

...es/@stdlib/number/float32/base/signbit/include/stdlib/number/float32/base/signbit/signbitf.h

+/**
+* Returns a `boolean` indicating if the sign bit for a single-precision floating-point number is on (`true`) or off (`false`).
+*/
+bool stdlib_base_float32_signbit( const float x );


Needs to be updated. And even if returning a bool, L22 would not be correct.

kgryte · 2022-11-15T20:41:51Z

lib/node_modules/@stdlib/number/float32/base/signbit/lib/native.js

+* // returns true
+*/
+function signbitf(  x  ) {
+	return addon(  x  );


As the native add-on will be return an int32, need to wrap with the Boolean constructor.

kgryte · 2022-11-15T20:42:30Z

lib/node_modules/@stdlib/number/float32/base/signbit/manifest.json

+			"libraries": [],
+			"libpath": [],
+			"dependencies": [
+				"@stdlib/math/base/special/signbitf",


This is incorrect and should not be included.

stdlib-bot · 2024-09-14T16:44:06Z

PR Commit Message

feat: add C implementation for `number/float32/base/signbit`

PR-URL: https://github.com/stdlib-js/stdlib/pull/623
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

stdlib-bot · 2024-09-21T19:49:33Z

PR Commit Message

feat: add C implementation for `number/float32/base/signbit`

PR-URL: https://github.com/stdlib-js/stdlib/pull/623

Please review the above commit message and make any necessary adjustments.

Planeshifter changed the title ~~Add C implementation~~ Add C implementation for @stdlib/number/float32/base/signbit Nov 15, 2022

Planeshifter requested a review from kgryte November 15, 2022 01:23

Planeshifter assigned stdlib-bot and unassigned stdlib-bot Nov 15, 2022

stdlib-js deleted a comment from github-actions bot Nov 15, 2022

Planeshifter commented Nov 15, 2022

View reviewed changes

kgryte reviewed Nov 15, 2022

View reviewed changes

Planeshifter force-pushed the number/float32/base/signbit branch from ad5d38f to dae22cf Compare September 14, 2024 16:13

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Sep 14, 2024

Planeshifter force-pushed the number/float32/base/signbit branch from dae22cf to eabbf5e Compare September 14, 2024 16:22

Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Ready To Merge A pull request which is ready to be merged. labels Sep 14, 2024

stdlib-js deleted a comment from github-actions bot Sep 14, 2024

Planeshifter force-pushed the number/float32/base/signbit branch from eabbf5e to 33534e5 Compare September 14, 2024 16:41

Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Ready To Merge A pull request which is ready to be merged. labels Sep 14, 2024

Planeshifter removed the Ready To Merge A pull request which is ready to be merged. label Sep 14, 2024

kgryte added the Do Not Merge Pull request which should not be merged. label Sep 16, 2024

Planeshifter and others added 14 commits September 21, 2024 15:46

Add C implementation

4a76c61

Scaffold number/float32/base/signbit package files

23e9a28

Delete files

0bf0939

Scaffold number/float32/base/signbit package files

0b7c141

Delete files

b6675ab

Scaffold number/float32/base/signbit package files

817c6b5

Delete files

0ac1349

Scaffold number/float32/base/signbit package files

174edb5

Delete files

fca8f55

Scaffold number/float32/base/signbit package files

b22e5a6

Delete files

896734c

Scaffold number/float32/base/signbit package files

8f74c7f

Delete files

986fad0

Scaffold number/float32/base/signbit package files

fc95921

Planeshifter force-pushed the number/float32/base/signbit branch from 33534e5 to fc95921 Compare September 21, 2024 19:47

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Sep 21, 2024

Planeshifter removed the Ready To Merge A pull request which is ready to be merged. label Sep 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add C implementation for `number/float32/base/signbit` #623

feat: add C implementation for `number/float32/base/signbit` #623

Planeshifter commented Nov 15, 2022 •

edited by kgryte

Loading

github-actions bot commented Nov 15, 2022

Planeshifter left a comment

Planeshifter Nov 15, 2022

kgryte Nov 15, 2022 •

edited

Loading

kgryte Nov 15, 2022

kgryte Nov 15, 2022

kgryte Nov 15, 2022

kgryte Nov 15, 2022

kgryte Nov 15, 2022

kgryte Nov 15, 2022

kgryte Nov 15, 2022

kgryte Nov 15, 2022

stdlib-bot commented Sep 14, 2024

stdlib-bot commented Sep 21, 2024


		#### stdlib_base_float32_signbit( x )

		Returns a `boolean` indicating if the sign bit for a [single-precision floating-point number][ieee754] is on (`true`) or off (`false`).

feat: add C implementation for number/float32/base/signbit #623

Are you sure you want to change the base?

feat: add C implementation for number/float32/base/signbit #623

Conversation

Planeshifter commented Nov 15, 2022 • edited by kgryte Loading

Description

Related Issues

Questions

Other

Checklist

github-actions bot commented Nov 15, 2022

Notes

Planeshifter left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kgryte Nov 15, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stdlib-bot commented Sep 14, 2024

PR Commit Message

stdlib-bot commented Sep 21, 2024

PR Commit Message

feat: add C implementation for `number/float32/base/signbit` #623

feat: add C implementation for `number/float32/base/signbit` #623

Planeshifter commented Nov 15, 2022 •

edited by kgryte

Loading

kgryte Nov 15, 2022 •

edited

Loading