Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/nanmin #3004

Merged
merged 6 commits into from
Oct 19, 2024
Merged

feat: add C implementation for math/base/special/nanmin #3004

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0aa0201
feat: add C implementation for math/base/special/nanmin
gunjjoshi Oct 13, 2024
852bde0
docs: use correct NAPI function
gunjjoshi Oct 13, 2024
9fedf44
Merge branch 'develop' of https://github.com/stdlib-js/stdlib into pr…
kgryte Oct 19, 2024
eca97f0
Apply suggestions from code review
kgryte Oct 19, 2024
cdfcf8e
Update test.native.js
kgryte Oct 19, 2024
35820ac
Update test.js
gunjjoshi Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/node_modules/@stdlib/math/base/special/nanmin/test/test.native.js
View file
Open in desktop
kgryte marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -46,18 +46,18 @@ tape( 'the function returns `NaN` if both operands are `NaN`', opts, function te
var v;

v = nanmin( NaN, NaN );
t.strictEqual( isnan( v ), true, 'returns NaN value' );
t.strictEqual( isnan( v ), true, 'returns expected value' );
t.end();
});

tape( 'the function returns the non-NaN value if one of the operands is `NaN`', opts, function test( t ) {
var v;

v = nanmin( NaN, 3.14 );
t.strictEqual( v, 3.14, 'returns not NaN value' );
t.strictEqual( v, 3.14, 'returns expected value' );

v = nanmin( 4.2, NaN );
t.strictEqual( v, 4.2, 'returns not NaN value' );
t.strictEqual( v, 4.2, 'returns expected value' );

t.end();
});
Expand All @@ -66,10 +66,10 @@ tape( 'the function returns the minimum value', opts, function test( t ) {
var v;

v = nanmin( 5.2, 3.14 );
t.strictEqual( v, 3.14, 'returns min value' );
t.strictEqual( v, 3.14, 'returns expected value' );

v = nanmin( -4.2, 3.14 );
t.strictEqual( v, -4.2, 'returns min value' );
t.strictEqual( v, -4.2, 'returns expected value' );

t.end();
});
Loading