-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add math/base/special/gcdf
#2997
base: develop
Are you sure you want to change the base?
Conversation
@Planeshifter Ready for initial review! |
Signed-off-by: Aayush Khanna <[email protected]>
lib/node_modules/@stdlib/math/base/special/gcdf/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/gcdf/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/gcdf/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/gcdf/benchmark/c/native/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/gcdf/benchmark/c/native/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/gcdf/benchmark/julia/REQUIRE
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/gcdf/benchmark/julia/benchmark.jl
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/gcdf/benchmark/python/benchmark.py
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/gcdf/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/gcdf/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/gcdf/docs/types/test.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/gcdf/examples/c/example.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/gcdf/examples/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/gcdf/examples/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/gcdf/include/stdlib/math/base/special/gcdf.h
Outdated
Show resolved
Hide resolved
*/ | ||
|
||
#include "stdlib/math/base/special/gcdf.h" | ||
#include "stdlib/math/base/special/fmod.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to use the single-precision implementation of fmod
here, i.e., fmodf
, which we do not have currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies. I did look for it in #649 but I did not see it there, so I went ahead and used fmod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this. #649 is updated now, fmodf
has been added.
Thanks @aayush0325, we'll require |
Thanks for your time @gunjjoshi , I have applied the changes from the code review, please ping this PR when |
Resolves part of #649 .
Description
This pull request:
math/base/special/gcdf
Related Issues
This pull request:
Questions
No.
Other
Checklist
@stdlib-js/reviewers