Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C implementation for math/base/special/fast/uint32-log2 #1946

Merged
Show file tree
Hide file tree
Changes from 25 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
9a32b1e
feat: add C implementation for math/base/special/fast/uint32-log2
performant23 Mar 18, 2024
4e216df
Update main.c
performant23 Mar 18, 2024
9c55669
Update README.md
performant23 Mar 18, 2024
f1a05d3
chore: apply suggestions from code review
Pranavchiku Mar 19, 2024
fc31378
chore: apply suggestions from code review
Pranavchiku Mar 19, 2024
822707a
chore: apply suggestions from code review
Pranavchiku Mar 19, 2024
e7bd520
chore: apply suggestions from code review
Pranavchiku Mar 19, 2024
f097ea7
Update native.js - fix return type
performant23 Mar 19, 2024
4bc339a
Update native.js - remove import
performant23 Mar 19, 2024
ed2ac1e
Update main.c
performant23 Mar 20, 2024
c8c1cde
Apply suggestions from code review
kgryte Mar 23, 2024
a6891ef
Apply suggestions from code review
kgryte Mar 23, 2024
a3cabbc
Apply suggestions from code review
kgryte Mar 23, 2024
1c7b05d
Update addon.c
performant23 Mar 23, 2024
1b98855
Update addon.c - spacing
performant23 Mar 23, 2024
bd11bb5
Update addon.c - spacing and initialization
performant23 Mar 23, 2024
d6da18a
Update manifest.json
performant23 Mar 23, 2024
a16920c
Update manifest.json
performant23 Mar 23, 2024
e5dd306
Update main.c - add extended comment string
performant23 Mar 23, 2024
85ebd4b
Update addon.c
performant23 Mar 23, 2024
304366f
Update lib/node_modules/@stdlib/math/base/special/fast/uint32-log2/sr…
performant23 Mar 23, 2024
31c5b30
Apply suggestions from code review
kgryte Mar 23, 2024
4b3f669
Apply suggestions from code review
kgryte Mar 23, 2024
b67dd05
Update addon.c
performant23 Mar 23, 2024
85a450d
Update manifest.json
performant23 Mar 23, 2024
77e65d5
Apply suggestions from code review
kgryte Mar 23, 2024
e4248da
Apply suggestions from code review
kgryte Mar 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,97 @@ for ( i = 1; i < 101; i++ ) {

<!-- /.examples -->

<!-- C interface documentation. -->

* * *

<section class="c">

## C APIs

<!-- Section to include introductory text. Make sure to keep an empty line after the intro `section` element and another before the `/section` close. -->

<section class="intro">

</section>

<!-- /.intro -->

<!-- C usage documentation. -->

<section class="usage">

### Usage

```c
#include "stdlib/math/base/special/fast/uint32_log2.h"
```

#### stdlib_base_fast_uint32_log2( x )

Returns an **approximate** [binary logarithm][binary-logarithm] of an unsigned 32-bit integer `x`.

```c
#include <stdint.h>

uint32_t out = stdlib_base_fast_uint32_log2( 4 );
// returns 2

out = stdlib_base_fast_uint32_log2( 9 );
// returns 3
```

The function accepts the following arguments:

- **x**: `[in] uint32_t` input value.

```c
uint32_t stdlib_base_fast_uint32_log2( const uint32_t x );
```

</section>

<!-- /.usage -->

<!-- C API usage notes. Make sure to keep an empty line after the `section` element and another before the `/section` close. -->

<section class="notes">

</section>

<!-- /.notes -->

<!-- C API usage examples. -->

<section class="examples">

### Examples

```c
#include "stdlib/math/base/special/fast/uint32_log2.h"
#include <stdio.h>
#include <stdint.h>

int main( void ) {
const uint32_t x[] = { 5, 7, 10, 22, 98 };

uint32_t y;
int i;
for ( i = 0; i < 5; i++ ) {
y = stdlib_base_fast_uint32_log2( x[ i ] );
printf( "uint32_log2(%u) = %u\n", x[ i ], y );
}
}
```

</section>

<!-- /.examples -->

</section>

<!-- /.c -->

<!-- Section for related `stdlib` packages. Do not manually edit this section, as it is automatically populated. -->

<section class="related">
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
/**
* @license Apache-2.0
*
* Copyright (c) 2024 The Stdlib Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

'use strict';

// MODULES //

var resolve = require( 'path' ).resolve;
var bench = require( '@stdlib/bench' );
var minstd = require( '@stdlib/random/base/minstd-shuffle' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var tryRequire = require( '@stdlib/utils/try-require' );
var pkg = require( './../package.json' ).name;


// VARIABLES //

var log2Uint32 = tryRequire( resolve( __dirname, './../lib/native.js' ) );
var opts = {
'skip': ( log2Uint32 instanceof Error )
};


// MAIN //

bench( pkg+'::native', opts, function benchmark( b ) {
var y;
var i;

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
y = log2Uint32( minstd() >>> 0 );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
}
b.toc();
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
b.pass( 'benchmark finished' );
b.end();
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,146 @@
#/
# @license Apache-2.0
#
# Copyright (c) 2024 The Stdlib Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#/

# VARIABLES #

ifndef VERBOSE
QUIET := @
else
QUIET :=
endif

# Determine the OS ([1][1], [2][2]).
#
# [1]: https://en.wikipedia.org/wiki/Uname#Examples
# [2]: http://stackoverflow.com/a/27776822/2225624
OS ?= $(shell uname)
ifneq (, $(findstring MINGW,$(OS)))
OS := WINNT
else
ifneq (, $(findstring MSYS,$(OS)))
OS := WINNT
else
ifneq (, $(findstring CYGWIN,$(OS)))
OS := WINNT
else
ifneq (, $(findstring Windows_NT,$(OS)))
OS := WINNT
endif
endif
endif
endif

# Define the program used for compiling C source files:
ifdef C_COMPILER
CC := $(C_COMPILER)
else
CC := gcc
endif

# Define the command-line options when compiling C files:
CFLAGS ?= \
-std=c99 \
-O3 \
-Wall \
-pedantic

# Determine whether to generate position independent code ([1][1], [2][2]).
#
# [1]: https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#Code-Gen-Options
# [2]: http://stackoverflow.com/questions/5311515/gcc-fpic-option
ifeq ($(OS), WINNT)
fPIC ?=
else
fPIC ?= -fPIC
endif

# List of includes (e.g., `-I /foo/bar -I /beep/boop/include`):
INCLUDE ?=

# List of source files:
SOURCE_FILES ?=

# List of libraries (e.g., `-lopenblas -lpthread`):
LIBRARIES ?=

# List of library paths (e.g., `-L /foo/bar -L /beep/boop`):
LIBPATH ?=

# List of C targets:
c_targets := benchmark.out


# RULES #

#/
# Compiles source files.
#
# @param {string} [C_COMPILER] - C compiler (e.g., `gcc`)
# @param {string} [CFLAGS] - C compiler options
# @param {(string|void)} [fPIC] - compiler flag determining whether to generate position independent code (e.g., `-fPIC`)
# @param {string} [INCLUDE] - list of includes (e.g., `-I /foo/bar -I /beep/boop/include`)
# @param {string} [SOURCE_FILES] - list of source files
# @param {string} [LIBPATH] - list of library paths (e.g., `-L /foo/bar -L /beep/boop`)
# @param {string} [LIBRARIES] - list of libraries (e.g., `-lopenblas -lpthread`)
#
# @example
# make
#
# @example
# make all
#/
all: $(c_targets)

.PHONY: all

#/
# Compiles C source files.
#
# @private
# @param {string} CC - C compiler (e.g., `gcc`)
# @param {string} CFLAGS - C compiler options
# @param {(string|void)} fPIC - compiler flag determining whether to generate position independent code (e.g., `-fPIC`)
# @param {string} INCLUDE - list of includes (e.g., `-I /foo/bar`)
# @param {string} SOURCE_FILES - list of source files
# @param {string} LIBPATH - list of library paths (e.g., `-L /foo/bar`)
# @param {string} LIBRARIES - list of libraries (e.g., `-lopenblas`)
#/
$(c_targets): %.out: %.c
$(QUIET) $(CC) $(CFLAGS) $(fPIC) $(INCLUDE) -o $@ $(SOURCE_FILES) $< $(LIBPATH) -lm $(LIBRARIES)

#/
# Runs compiled benchmarks.
#
# @example
# make run
#/
run: $(c_targets)
$(QUIET) ./$<

.PHONY: run

#/
# Removes generated files.
#
# @example
# make clean
#/
clean:
$(QUIET) -rm -f *.o *.out

.PHONY: clean
Loading
Loading