-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add utils/some-own-by
#1437
feat: add utils/some-own-by
#1437
Conversation
…utils Add a utility to test whether some own properties of a provided object satisfies a predicate function Fixes: stdlib-js#821
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good progress, requested a few changes, once done this PR can be reviewed.
…utils (Revision 1) Add a utility to test whether some own properties of a provided object satisfies a predicate function Signed-off-by: Pranavchiku [email protected]
…utils (Revision 1) Add a utility to test whether some own properties of a provided object satisfies a predicate function Signed-off-by: Pranavchiku [email protected]
utils/some-own-by
Hi all, I have applied changes from code review but when I'm trying to push the code, I'm getting this:
I checked the examples included as markdown in README but I'm not sure what's causing the error (While it says invalid unicode escape sequence, the marked down examples don't use unicode esape sequences and checked the paths too). So, I'd be really grateful if you could guide me on solving this! Thank you so much! |
Add a utility to test whether some own properties of a provided object satisfies a predicate function Signed-off-by: Pranavchiku [email protected]
Add a utility to test whether some own properties of a provided object satisfies a predicate function Signed-off-by: Pranavchiku [email protected]
Add a utility to test whether some own properties of a provided object satisfies a predicate function Signed-off-by: Pranavchiku [email protected]
…utils (Revision 2) Apply changes from code review Signed-off-by: Pranavchiku [email protected]
…utils (Revision 3) Apply changes from code review (Except README.md) Signed-off-by: Pranavchiku [email protected]
Co-authored-by: Pranav <[email protected]> Signed-off-by: Rutam <[email protected]>
Thank you so much for the review! I have made the required changes. Please do let me know if there are any additional changes needed! |
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
@performant23 Thanks; looked good! Will merge once CI passes. (Ignore the suggestions and edits; I changed the iteration to directly loop over the object's keys without usage of |
Signed-off-by: Philipp Burckhardt <[email protected]>
Add a utility to test whether some own properties of a provided object satisfies a predicate function
Fixes: #821
Resolves #821.
Description
This pull request:
Related Issues
This pull request:
@stdlib/utils/some-own-by
#821@stdlib/utils/some-own-by
#821Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers