Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: add math/base/special/asinf #1944

Closed
3 tasks done
gunjjoshi opened this issue Mar 18, 2024 · 5 comments · Fixed by #2030
Closed
3 tasks done

[RFC]: add math/base/special/asinf #1944

gunjjoshi opened this issue Mar 18, 2024 · 5 comments · Fixed by #2030
Assignees
@gunjjoshi
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 3 Likely to be challenging but manageable. Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. Math Issue or pull request specific to math functionality. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.

Comments

@gunjjoshi
Copy link
Member

gunjjoshi commented Mar 18, 2024 •
edited
Loading

Description

This RFC proposes adding math/base/special/asinf, which would be a single precision implementation for math/base/special/asin.

float stdlib_base_asinf( const float x )

Related Issues

Related issues #649.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@gunjjoshi
Copy link
Member Author

I would like to work on this.

@gunjjoshi
Copy link
Member Author

gunjjoshi commented Mar 18, 2024 •
edited
Loading

Also, @kgryte, we will need PI02F for this. But as of now, the single precision float32 constant for pi/2 is not implemented. So, should I first implement that, or should I directly use hardcoded value for that ?

@gunjjoshi gunjjoshi mentioned this issue Mar 18, 2024
Closed
1 task
@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. difficulty: 3 Likely to be challenging but manageable. Math Issue or pull request specific to math functionality. Accepted RFC feature request which has been accepted. priority: Normal Normal priority concern or feature request. JavaScript Issue involves or relates to JavaScript. C Issue involves or relates to C. and removed Accepted RFC feature request which has been accepted. labels Mar 18, 2024
@kgryte
Copy link
Member

kgryte commented Mar 18, 2024

@gunjjoshi Thanks for opening this. This sounds good.

Re: pi/2. In a separate PR, can you add @stdlib/constants/float32/half-pi? Should be done similarly to https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/constants/float32/sqrt-eps and https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/constants/float64/half-pi (the float64 equivalent).

@kgryte
Copy link
Member

kgryte commented Mar 18, 2024

I imagine there will be a number of constants missing in float32 that have float64 counterparts and will be needed in single-precision implementations.

@gunjjoshi
Copy link
Member Author

gunjjoshi commented Mar 19, 2024 •
edited
Loading

Yes @kgryte, I will make a separate PR for that.

Also, it is correct that we have missing constants in float32. We would be definitely needing them in near future, if we're aiming for single precision implementation of more, if not all of the packages in math/base/special.

@gunjjoshi gunjjoshi mentioned this issue Mar 19, 2024
Merged
kgryte added a commit that referenced this issue Mar 19, 2024
@gunjjoshi @kgryte
feat: add constants/float32/half-pi
afb14b3 
PR-URL: 	#1953
Ref: #1944
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: GUNJ JOSHI <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
@gunjjoshi gunjjoshi mentioned this issue Mar 25, 2024
Merged
1 task
kgryte added a commit that referenced this issue Mar 25, 2024
@gunjjoshi @kgryte
feat: add math/base/special/asinf
0038b4b 
PR-URL: 	#2030
Closes: #1944
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: GUNJ JOSHI <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gunjjoshi gunjjoshi

Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 3 Likely to be challenging but manageable. Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. Math Issue or pull request specific to math functionality. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add math/base/special/asinf
feat: add math/base/special/asinf
2 participants
@kgryte @gunjjoshi