feat: add math/base/special/asinf

[gunjjoshi]

Resolves #1944.

Description

What is the purpose of this pull request?

This pull request:

• adds math/base/special/asinf, which computes the arcsine of a single precision floating point number.

Related Issues

Does this pull request have any related issues?

This pull request:

• fixes [RFC]: add math/base/special/asinf #1944.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[gunjjoshi]

#1953 must be merged before this one. In this PR, I have hardcoded the value for pi/2. Once the constant is added from #1953, we can use that here instead of the hardcoded value.

[gunjjoshi]

This PR can be reviewed now.

[Planeshifter]

Left two comments; otherwise this looks all good and should be ready to merge soon! Thank you!

[gunjjoshi]

Made changes suggested by you @kgryte. Along with that, modified the JS implementation. Also, what changes do we need to make in evalpoly ?

[kgryte]

@gunjjoshi I've updated evalpoly-compile and evalrational-compile to now support single-precision floating-point emulation. The latest develop has the latest changes. If you merge in those changes, you should be able to now generate the correct poly_p.js file.

[gunjjoshi]

Hey @kgryte, while incorporating changes, after the latest merge, the file lib/node_modules/@stdlib/random/base/minstd-shuffle/README.md is having some errors in examples. And some tests too, along with that, which are unrelated to this package. This is completely out of the context for this package.

[kgryte]

@gunjjoshi Looks like something went awry with your merge, as now changes unrelated to this PR are showing up on GitHub.

You may be best to just open up a fresh PR with the proposed changes to asinf.

[kgryte]

Did you do an explicit git pull upstream develop into your local branch? Or how did you attempt to merge in the latest changes?

[gunjjoshi]

To merge the latest changes, I did a git pull on develop, and then git merge develop on asinf branch.
What went wrong with me here @kgryte ?

Sure, I'll make a fresh PR for this.

[kgryte]

From your commit history, I am not seeing that you pushed up the merge commit. https://github.com/stdlib-js/stdlib/pull/1950/commits

[gunjjoshi]

Yes @kgryte, I only committed those files which I changed, and not all of them.

[kgryte]

Okay. When you merge locally, you still need to push up to your remote fork on the branch you are working on the merge commit. That merge commit is what's missing in your Git history for this branch.

[kgryte]

Can you provide the sequence of bash commands you used when merging and pushing to your remote?

[gunjjoshi]

Okay, getting it now.

The sequence of commands I used were :

• git checkout develop
• git pull
• git checkout asinf
• git merge develop
  (Then, I only staged the files that I had modified.)
• git commit -m "message"
• git push

[kgryte]

Yeah, you want to first commit any changes files, then merge, resolve any potential conflicts, commit the merge, and then push.

[kgryte]

Regardless, you should be able to simply copy over the changed files to a new branch, push that up, and open a fresh PR.

[gunjjoshi]

Understood it now. Thanks for sharing.
Yes, I will be copying over the changes to a new branch and will make a fresh PR.

[gunjjoshi]

Made a new PR at #2030 @kgryte. We can close this now.