-
-
Notifications
You must be signed in to change notification settings - Fork 448
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat!: add support for stacks in
blas/sdot
BREAKING CHANGE: return an ndarray, rather than a scalar This commit changes the return value from a scalar to an ndarray. Previously, the function only operated on one-dimensional ndarrays and returned a scalar value. Now, the function operates on ndarrays of arbitrary rank and always returns an ndarray. In order to migrate, for one-dimensional input ndarrays, users should call `out.get()` in order to retrieve the scalar dot product. PR-URL: #2895 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>
- Loading branch information
Showing
13 changed files
with
811 additions
and
159 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
122 changes: 122 additions & 0 deletions
122
lib/node_modules/@stdlib/blas/sdot/benchmark/benchmark.stack.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,122 @@ | ||
/** | ||
* @license Apache-2.0 | ||
* | ||
* Copyright (c) 2020 The Stdlib Authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
// MODULES // | ||
|
||
var bench = require( '@stdlib/bench' ); | ||
var isnan = require( '@stdlib/math/base/assert/is-nan' ); | ||
var pow = require( '@stdlib/math/base/special/pow' ); | ||
var uniform = require( '@stdlib/random/array/uniform' ); | ||
var numel = require( '@stdlib/ndarray/base/numel' ); | ||
var array = require( '@stdlib/ndarray/array' ); | ||
var pkg = require( './../package.json' ).name; | ||
var sdot = require( './../lib/main.js' ); | ||
|
||
|
||
// VARIABLES // | ||
|
||
var OPTS = { | ||
'dtype': 'float32' | ||
}; | ||
|
||
|
||
// FUNCTIONS // | ||
|
||
/** | ||
* Creates a benchmark function. | ||
* | ||
* @private | ||
* @param {PositiveIntegerArray} shape - array shape | ||
* @returns {Function} benchmark function | ||
*/ | ||
function createBenchmark( shape ) { | ||
var x; | ||
var y; | ||
var N; | ||
var o; | ||
|
||
N = numel( shape ); | ||
o = { | ||
'shape': shape | ||
}; | ||
x = array( uniform( N, -100.0, 100.0, OPTS ), o ); | ||
y = array( uniform( N, -100.0, 100.0, OPTS ), o ); | ||
|
||
return benchmark; | ||
|
||
/** | ||
* Benchmark function. | ||
* | ||
* @private | ||
* @param {Benchmark} b - benchmark instance | ||
*/ | ||
function benchmark( b ) { | ||
var d; | ||
var i; | ||
|
||
b.tic(); | ||
for ( i = 0; i < b.iterations; i++ ) { | ||
d = sdot( x, y ); | ||
if ( isnan( d.iget( 0 ) ) ) { | ||
b.fail( 'should not return NaN' ); | ||
} | ||
} | ||
b.toc(); | ||
if ( isnan( d.iget( 0 ) ) ) { | ||
b.fail( 'should not return NaN' ); | ||
} | ||
b.pass( 'benchmark finished' ); | ||
b.end(); | ||
} | ||
} | ||
|
||
|
||
// MAIN // | ||
|
||
/** | ||
* Main execution sequence. | ||
* | ||
* @private | ||
*/ | ||
function main() { | ||
var shape; | ||
var min; | ||
var max; | ||
var N; | ||
var f; | ||
var i; | ||
|
||
min = 1; // 10^min | ||
max = 6; // 10^max | ||
|
||
for ( i = min; i <= max; i++ ) { | ||
N = pow( 10, i ); | ||
|
||
shape = [ 2, N/2 ]; | ||
f = createBenchmark( shape ); | ||
bench( pkg+'::stacks:size='+N+',ndims='+shape.length+',shape=('+shape.join( ',' )+')', f ); | ||
|
||
shape = [ N/2, 2 ]; | ||
f = createBenchmark( shape ); | ||
bench( pkg+'::stacks:size='+N+',ndims='+shape.length+',shape=('+shape.join( ',' )+')', f ); | ||
} | ||
} | ||
|
||
main(); |
Oops, something went wrong.
97bba2a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverage Report
The above coverage report was generated for the changes in this push.