Skip to content

Commit

Permalink
feat!: remove out argument support in croundn and add C implementations
Browse files Browse the repository at this point in the history
This commits removes support for providing an output array to `croundn` and, instead, assumes that a complex number object is provided and accordingly returns a complex number object as the result.

As part of this PR, C implementations are added for `roundn` and `croundn`.

BREAKING CHANGE: remove support for `out` argument

To migrate, users should provide a complex number object and handle a complex number object return value.

PR-URL: 	#1009
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Private-ref: stdlib-js/todo#1454
  • Loading branch information
steff456 and kgryte authored Aug 25, 2023
1 parent 36d8cb7 commit 33b55e6
Show file tree
Hide file tree
Showing 44 changed files with 3,484 additions and 557 deletions.
142 changes: 71 additions & 71 deletions lib/node_modules/@stdlib/math/base/special/ceil/manifest.json
Original file line number Diff line number Diff line change
@@ -1,73 +1,73 @@
{
"options": {
"task": "build"
},
"fields": [
{
"field": "src",
"resolve": true,
"relative": true
},
{
"field": "include",
"resolve": true,
"relative": true
},
{
"field": "libraries",
"resolve": false,
"relative": false
},
{
"field": "libpath",
"resolve": true,
"relative": false
}
],
"confs": [
{
"task": "build",
"src": [
"./src/ceil.c"
],
"include": [
"./include"
],
"libraries": [
"-lm"
],
"libpath": [],
"dependencies": [
"@stdlib/math/base/napi/unary"
]
},
{
"task": "benchmark",
"src": [
"./src/ceil.c"
],
"include": [
"./include"
],
"libraries": [
"-lm"
],
"libpath": [],
"dependencies": []
},
{
"task": "examples",
"src": [
"./src/ceil.c"
],
"include": [
"./include"
],
"libraries": [
"-lm"
],
"libpath": [],
"dependencies": []
}
]
"options": {
"task": "build"
},
"fields": [
{
"field": "src",
"resolve": true,
"relative": true
},
{
"field": "include",
"resolve": true,
"relative": true
},
{
"field": "libraries",
"resolve": false,
"relative": false
},
{
"field": "libpath",
"resolve": true,
"relative": false
}
],
"confs": [
{
"task": "build",
"src": [
"./src/ceil.c"
],
"include": [
"./include"
],
"libraries": [
"-lm"
],
"libpath": [],
"dependencies": [
"@stdlib/math/base/napi/unary"
]
},
{
"task": "benchmark",
"src": [
"./src/ceil.c"
],
"include": [
"./include"
],
"libraries": [
"-lm"
],
"libpath": [],
"dependencies": []
},
{
"task": "examples",
"src": [
"./src/ceil.c"
],
"include": [
"./include"
],
"libraries": [
"-lm"
],
"libpath": [],
"dependencies": []
}
]
}
Loading

1 comment on commit 33b55e6

@stdlib-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage Report

Package Statements Branches Functions Lines
math/base/special/ceil $\color{green}157/157$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}157/157$
$\color{green}+100.00\%$
math/base/special/croundn $\color{red}250/254$
$\color{green}+98.43\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{red}1/2$
$\color{green}+50.00\%$
$\color{red}250/254$
$\color{green}+98.43\%$
math/base/special/roundn $\color{red}276/279$
$\color{green}+98.92\%$
$\color{green}22/22$
$\color{green}+100.00\%$
$\color{red}1/2$
$\color{green}+50.00\%$
$\color{red}276/279$
$\color{green}+98.92\%$

The above coverage report was generated for the changes in this push.

Please sign in to comment.