Auto-generated commit

stdlib-js · Apr 18, 2024 · 243deb1 · 243deb1
1 parent f2193b2
commit 243deb1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/base/idamax/manifest.json b/base/idamax/manifest.json
@@ -48,6 +48,7 @@
         "@stdlib/napi/argv",
         "@stdlib/napi/argv-int64",
         "@stdlib/napi/argv-strided-float64array",
+        "@stdlib/napi/create-int32",
         "@stdlib/math/base/special/abs"
       ]
     },
@@ -166,6 +167,7 @@
         "@stdlib/napi/argv",
         "@stdlib/napi/argv-int64",
         "@stdlib/napi/argv-strided-float64array",
+        "@stdlib/napi/create-int32",
         "@stdlib/math/base/special/abs"
       ]
     },
@@ -339,6 +341,7 @@
         "@stdlib/napi/argv",
         "@stdlib/napi/argv-int64",
         "@stdlib/napi/argv-strided-float64array",
+        "@stdlib/napi/create-int32",
         "@stdlib/math/base/special/abs"
       ]
     },

diff --git a/base/idamax/src/addon.c b/base/idamax/src/addon.c
@@ -21,6 +21,7 @@
 #include "stdlib/napi/argv.h"
 #include "stdlib/napi/argv_int64.h"
 #include "stdlib/napi/argv_strided_float64array.h"
+#include "stdlib/napi/create_int32.h"
 #include <node_api.h>
 #include <assert.h>
 
@@ -38,9 +39,9 @@ static napi_value addon( napi_env env, napi_callback_info info ) {
 	STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 2 );
 	STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, strideX, argv, 1 );
 
-	napi_value idx;
-	napi_status status = napi_create_int32( env, c_idamax( N, X, strideX ), &idx ); // TODO: revisit once we support 64-bit integers as return values and 64 integers more generally in JavaScript
-	assert( status == napi_ok );
+	// TODO: revisit once we support 64-bit integers as return values and 64 integers more generally in JavaScript
+	STDLIB_NAPI_CREATE_INT32( env, c_idamax( N, X, strideX ), idx );
+
 	return idx;
 }