Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: recover_matrix #6553

Merged
merged 1 commit into from
Sep 17, 2024
Merged

add: recover_matrix #6553

merged 1 commit into from
Sep 17, 2024

Conversation

agnxsh
Copy link

@agnxsh agnxsh commented Sep 16, 2024

This Pr adds the second part to data column reconstruction, where the data columns that would not be unavailable via gossip or req/resp would effectively be reconstructed within the slot period.

ref: https://github.com/ethereum/consensus-specs/blob/v1.5.0-alpha.5/specs/_features/eip7594/das-core.md#recover_matrix

Copy link

github-actions bot commented Sep 16, 2024

Unit Test Results

         9 files  ±0    1 349 suites  ±0   55m 24s ⏱️ + 5m 40s
  5 144 tests +1    4 796 ✔️ +1  348 💤 ±0  0 ±0 
21 204 runs  +3  20 800 ✔️ +3  404 💤 ±0  0 ±0 

Results for commit 613d4ed. ± Comparison against base commit b3c8c71.

♻️ This comment has been updated with latest results.

@tersec
Copy link
Contributor

tersec commented Sep 16, 2024

#6554 fixes the build issues, for a certain definition of fix


let recoveredCellsAndKzgProofs =
recoverCellsAndKzgProofs(cell_indices, cells)
if not recoveredCellsAndKzgProofs.isOk:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if recoveredCellsAndKzgProofs.isErr:

@tersec tersec merged commit 1feeff4 into unstable Sep 17, 2024
11 checks passed
@tersec tersec deleted the dc4 branch September 17, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants