Fix blob syncing for Electra #6438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`BlobSidecar` requests on libp2p have a context prefix based on: > The `<context-bytes>` field is calculated as context = > `compute_fork_digest(fork_version, genesis_validators_root)` We currently only process blobs if that indicates Deneb, meaning that on Electra we incorrectly report `InvalidContextBytes` and refuse to process the blob response data. Fix this, and also ensure that the code no longer needs maintenance with every fork unrelated to blobs.
|
Spec is a bit vague about the fork digest to use, btw. When producing response, we use It doesn't hurt to just accept either deneb/electra fork digests when reading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlobSidecarrequests on libp2p have a context prefix based on:We currently only process blobs if that indicates Deneb, meaning that on Electra we incorrectly report
InvalidContextBytesand refuse to process the blob response data.Fix this, and also ensure that the code no longer needs maintenance with every fork unrelated to blobs.