cleanups

* remove unused variables
* avoid enlarging casts
* don't try to catch defects

blscurve/bls_batch_verifier.nim

@@ -54,31 +54,21 @@ type
 
     # Per-batch contexts for multithreaded batch verification
     batchContexts: seq[ContextMultiAggregateVerify[DST]]
-    when compileOption("threads"):
-      flows: seq[Flowvar[bool]]
 
 # Serial Batch Verifier
 # ----------------------------------------------------------------------
 
 func init*(T: type BatchedBLSVerifierCache): T =
   ## Initialise the cache for single-threaded usage
-  when compileOption("threads"):
-    BatchedBLSVerifierCache(
-      batchContexts: newSeq[ContextMultiAggregateVerify[DST]](1),
-      flows: @[]
-    )
-  else:
-    BatchedBLSVerifierCache(
-      batchContexts: newSeq[ContextMultiAggregateVerify[DST]](1),
-    )
-
+  BatchedBLSVerifierCache(
+    batchContexts: newSeq[ContextMultiAggregateVerify[DST]](1),
+  )
 
 when compileOption("threads"):
   func init*(T: type BatchedBLSVerifierCache, tp: Taskpool): T =
     ## Initialise the cache for multi-threaded usage
     BatchedBLSVerifierCache(
       batchContexts: newSeq[ContextMultiAggregateVerify[DST]](tp.numThreads),
-      flows: newSeq[Flowvar[bool]](tp.numThreads)
     )
 
 func batchVerifySerial*(

blscurve/miracl/common.nim

@@ -535,7 +535,7 @@ func fromBytes*(res: var BIG_384, a: openArray[byte]): bool =
   let length = if len(a) > MODBYTES_384: MODBYTES_384 else: len(a)
   for i in 0..<length:
     discard BIG_384_fshl(res, 8)
-    res[0] = res[0] + cast[Chunk](a[i])
+    res[0] = res[0] + Chunk(a[i])
   true
 
 func fromBytes*(res: var DBIG_384, a: openArray[byte]): bool =
@@ -547,7 +547,7 @@ func fromBytes*(res: var DBIG_384, a: openArray[byte]): bool =
   zeroMem(res.addr, sizeof(res))
   for rawByte in a:
     BIG_384_dshl(res, 8)
-    res[0] = res[0] + cast[Chunk](rawByte)
+    res[0] = res[0] + Chunk(rawByte)
   true
 
 func fromHex*(res: var BIG_384, a: string): bool {.inline.} =
@@ -556,7 +556,7 @@ func fromHex*(res: var BIG_384, a: string): bool {.inline.} =
   ## Returns ``true`` if conversion was successful.
   try:
     fromBytes(res, hexToSeqByte(a))
-  except ValueError, IndexError:
+  except ValueError:
     # TODO: change to exception-free
     # https://github.com/status-im/nim-blscurve/issues/57
     false
@@ -651,7 +651,7 @@ func fromHex*(res: var ECP2_BLS12381, a: string): bool {.inline.} =
   ## Returns ``true`` if conversion was successfull.
   try:
     fromBytes(res, hexToSeqByte(a))
-  except ValueError, IndexError:
+  except ValueError:
     # TODO: change to exception-free
     # https://github.com/status-im/nim-blscurve/issues/57
     false
@@ -737,7 +737,7 @@ func fromHex*(res: var ECP_BLS12381, a: string): bool {.inline.} =
   ## Returns ``true`` if conversion was successfull.
   try:
     fromBytes(res, hexToSeqByte(a))
-  except ValueError, IndexError:
+  except ValueError:
     # TODO: change to exception-free
     # https://github.com/status-im/nim-blscurve/issues/57
     false