Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] Improve handling of extreme pvalues in plots #141

Open
abought opened this issue Aug 29, 2018 · 0 comments
Open

[request] Improve handling of extreme pvalues in plots #141

abought opened this issue Aug 29, 2018 · 0 comments
Labels

Comments

@abought
Copy link
Member

abought commented Aug 29, 2018

Purpose

Per Peter/ Ryan discussion (record of notes for followup).

There are situations where a dataset might be fed to the client with pvalues outside the range allowed for floats. This includes analysis packages that give pvalues = 0 (eg BoltLMM), as well as client-side parsing of user-provided data (with pvalues).

If LocusZoom is asked to represent these values, the result (-log(10) = Infinity) causes no data to be displayed- see screenshot of a region with 2500 data points available. The default behavior should be to represent the point in a way that does not cause important associations to be dropped. One option would be to automatically detect infinity values, and render this as a discontinuous axis scale.

screen shot 2018-08-29 at 3 44 32 pm

For client side parsing, Ryan suggests an analogue of this function:
https://github.com/statgen/locuszoom-db/blob/master/locuszoom/db/loaders.py#L80-L108

@abought abought added the bug label Sep 12, 2018
@abought abought added this to the 0.9.0 milestone Nov 21, 2018
@abought abought removed this from the 0.9.0 milestone Jan 23, 2019
@abought abought added this to the 0.11.0 milestone Nov 22, 2019
@abought abought modified the milestones: 0.11.0, 0.12.0 May 19, 2020
@abought abought modified the milestones: 0.12.0, v0.13.0 Jun 3, 2020
@abought abought modified the milestones: v0.13.0, v0.14.0 Feb 10, 2021
@abought abought removed this from the v0.14.0 milestone Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant