Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y-axis does not render correctly when Infinity -log10pvalue is present #6

Closed
weinstockj opened this issue Mar 18, 2020 · 3 comments
Closed

Comments

@weinstockj
Copy link

I have a variant with a pvalue of 0 due to precision limitations. As plotted in localzoom, I see:

image

The data row looks like this:

CHROM POS REF ALT BETA SEBETA TSTAT PVALUE
chr6 325357 G A -9.744225 0.816393 -11.935698 0.000000e+00

@abought
Copy link
Member

abought commented Mar 18, 2020

Thanks for the bug report!

This is a known issue. Although I am closing this ticket to avoid duplication, it is an issue that we very much want to fix. See:
statgen/locuszoom#141

The main reason for the delay is that fixing this is not trivial (the code in question tries to do many things, and we want the fix to be reliable for all our various users). I'll try to keep you posted as options become available, even if it is not immediate.

Out of curiosity, what analysis program/version are you using? I've been a little surprised that new results are still subject to underflow errors. We had hoped that the problem would become less common as popular software improved, but clearly that hope was misplaced.

@abought abought closed this as completed Mar 18, 2020
@weinstockj
Copy link
Author

ok - thanks! I am using my own hand rolled program. I used scipy.stats to produce p-values, though not on log-scale. I'll switch to that.

@abought
Copy link
Member

abought commented Mar 18, 2020

Good to know, thanks!

Python is subject to this sort of underflow, but expressing things in log terms is an effective workaround. (our web app can parse small pvalues, like 10^-800, and convert to log if needed. But if the value is 0, there is not much that the parser can do)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants