Skip to content

Commit

Permalink
Merge branch 'release/0.2.3'
Browse files Browse the repository at this point in the history
  • Loading branch information
abought committed Mar 5, 2021
2 parents f66e686 + 6f2f923 commit caeaaf4
Show file tree
Hide file tree
Showing 6 changed files with 8,196 additions and 5,508 deletions.
21 changes: 15 additions & 6 deletions assets/vue/gwas_region.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import BatchScroller from 'localzoom/src/components/BatchScroller.vue';
import PlotPanes from 'localzoom/src/components/PlotPanes.vue';
import RegionPicker from 'localzoom/src/components/RegionPicker.vue';
import {setup_feature_metrics} from 'localzoom/src/util/metrics';
const MAX_REGION_SIZE = 1000000;
Expand Down Expand Up @@ -34,6 +35,11 @@
};
},
methods: {
activateMetrics() {
// After plot is created, initiate metrics capture
// TODO: This is a mite finicky; consider further refactoring in the future?
this.$refs.plotWidget.$refs.assoc_plot.callPlot(setup_feature_metrics);
},
activateBatchMode(regions) {
this.batch_mode_active = true;
this.batch_mode_regions = regions;
Expand Down Expand Up @@ -108,12 +114,15 @@
</div>
<div class="row">
<div class="col-md-12">
<plot-panes ref="plotWidget"
:dynamic_urls="true"
:assoc_layout="lz_layout" :assoc_sources="lz_sources"
:study_names="study_names" :has_credible_sets="true"
:build="build"
:chr="c_chr" :start="c_start" :end="c_end"/>
<plot-panes
ref="plotWidget"
:dynamic_urls="true"
:assoc_layout="lz_layout" :assoc_sources="lz_sources"
:study_names="study_names" :has_credible_sets="true"
:build="build"
:chr="c_chr" :start="c_start" :end="c_end"
@plot-created="activateMetrics"
/>
</div>
</div>
</div>
Expand Down
6 changes: 3 additions & 3 deletions compose/production/django/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
### Production dockerfile for the web app. JS and python are implemented as two steps of a multistage build.
# Multistage build

# Step 1: JS assets. Ensure that a change to package.json or yarn.lock invalidates the cache
# Step 1: JS assets. Ensure that a change to package.json or package-lock.json invalidates the cache
FROM node:fermium as jsbuilder
COPY ./package.json ./yarn.lock /build/
COPY ./package.json ./package-lock.json /build/
COPY . /build/
WORKDIR /build/
RUN yarn install --from-lockfile && yarn run prod
RUN npm install ci && npm run prod


# Step 2 (main): Django app. Install python dependencies, add volume mounts, and run.
Expand Down
11 changes: 9 additions & 2 deletions locuszoom_plotting_service/templates/pages/about.html
Original file line number Diff line number Diff line change
Expand Up @@ -102,14 +102,21 @@ <h3 class="faq" id="prepare-data">How should I prepare my data for uploading?</h
<h3 class="faq" id="missing-ld">Why is LD information not being shown for my data?</h3>
<p>
Sometimes, a region plot will be missing Linkage Disequilibrium (LD) information, and all points will be
shown in grey. The two most common reasons are as follows:
shown in grey. The three most common reasons are as follows:
</p>
<ol>
<li>
In order to provide LD annotations, your dataset must specify all of the information required to uniquely identify a variant (chromosome,
position, reference allele, alt allele). Reference and alt alleles should be defined in terms of the
selected genome build (GRCh37 or 38), and no additional information should be appended to the variant specifier.
</li>
<li>
Some datasets (especially meta-analysis) are known to use a different convention (like "effect" allele),
in which the reference and alt alleles are not consistently in the same column for every variant (row):
eg in one row, the effect allele might be the ref, and in another row it would be the alt.
There is no single convention for how to specify this across all the file formats that we support; hence we
ask users to specify "ref" and "alt" alleles as discrete columns for the variant identifier.
</li>
<li>
LD information is computed relative to the most significant SNP in the dataset. Thus, the LD reference SNP
must be present in the LD reference panel used. It is sometimes possible for the reference variant
Expand All @@ -121,7 +128,7 @@ <h3 class="faq" id="missing-ld">Why is LD information not being shown for my dat
This site uses an LD reference panel based on 1000G data, with several sub populations available.
Missing variants are most commonly a problem for build 37, which uses an older version of this reference panel.
As of Summer 2020, build GRCh38 datasets use an improved 1000G LD panel based on deep whole-genome sequencing.
Although we are exploring the possibility of additional LD reference panels, this is often difficult due to
Although we are exploring the possibility of additional LD reference panels, this is non-trivial due to
restrictions on public sharing of data.
</p>

Expand Down
Loading

0 comments on commit caeaaf4

Please sign in to comment.