Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fingerprint input on scene creation in webui #751

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ikmckenz
Copy link

@ikmckenz ikmckenz commented Feb 3, 2024

Mostly based this off the urlInput file. Tested working locally.

Resolves #476, which I guess was originally about adding some new hash type but has been edited to just "add fingerprints manually", which is what this does.

@ikmckenz
Copy link
Author

Rebased, and fixed formatting (yarn validate now passes)

@DogmaDragon
Copy link
Contributor

I strongly disagree with this being the default feature. While I can see a possible use case for this, without some safeguards it opens up a huge vector for abuse.

While Stash requirement is not ideal, it automatically adds certain safeguards like:

  • Hash being generated on actual file
  • File duration being sent along with the hash
  • Using the same algorithm as everyone else

@ikmckenz
Copy link
Author

ikmckenz commented Mar 5, 2024

Perhaps the entire “create scene” button in the webui should be configurable via a feature flag in that case? Operators who only want scenes via stash should disable entirely, and those operators who want it enabled will have users who can submit scenes with hashes in the webui.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Adding fingerprints manually
2 participants