feat: support liquid trades import #281

Zahrun · 2022-12-13T11:25:47Z

No description provided.

vercel · 2022-12-13T11:25:50Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
cryptotithe	❌ Failed (Inspect)		Dec 15, 2022 at 3:56PM (UTC)

starsoccer · 2022-12-13T14:04:00Z

src/parsers/trades/liquid/index.ts

+export default async function processData(importDetails: IImport): Promise<ITrade[]> {
+    const data: ILiquid[] = await getCSVData(importDetails.data) as ILiquid[];
+    const internalFormat: ITrade[] = [];
+    if (data.length < 1) {


Thoughts on moving line 30-34 into its own small function for all the parsers?

I feel like we just keep repeating this for all of them. Doesnt have to be in this PR but just curious what your thoughts are on it

See https://github.com/starsoccer/cryptotithe/pull/281/files#r1047200157

^ that link is not working for me for some reason

That’s because I changed the whole liquid code in between

src/parsers/trades/liquid/index.ts

starsoccer · 2022-12-13T14:06:28Z

src/parsers/trades/liquid/index.ts

+    if (data.length < 1) {
+        return internalFormat;
+    }
+    let splitTrade = data[0];


Just to confirm this is because again 1 trade = 2 line items?

What about if we did a for loop here(instead of for of) and then just incremented 2 each time?

Yes, this is because 1 trade = 2 lines.
This is also actually the reason for the if statement line 32-34. So that would be necessary for exchanges which split trades over multiple lines.

I think the new solution is much better. This liquid file has some very strange and inconsistent looking data as well, worse than Revolut.

src/types/locations.ts

Zahrun · 2022-12-14T00:44:48Z

In case you want to check the data
CryptoTransactions.csv

src/parsers/trades/liquid/index.ts

starsoccer · 2022-12-14T14:52:59Z

src/parsers/trades/liquid/index.ts

+            exchange : EXCHANGES.Liquid,
+            exchangeID : execution,
+        };
+        if (execution === '') {


Cant we just do !!execution?

I don’t know that notation. Here I’m testing if the executionID is '', when the cell is empty in the csv

I tried to replace the condition with !!execution, but the result is not the same, it ignores every line

starsoccer · 2022-12-14T14:53:36Z

src/parsers/trades/liquid/index.ts

+    const data: ILiquid[] = await getCSVData(importDetails.data) as ILiquid[];
+    const internalFormat: ITrade[] = [];
+    const sorted = data.reduce(groupByExecutionID, {});
+    for (const execution of Object.keys(sorted)) {


I beliieve we can do a for in loop here instead which will expose the key and the value rather then doing for of on the keys

I replaced with in loop

starsoccer · 2022-12-14T14:54:59Z

src/parsers/trades/liquid/index.ts

+                        break;
+                    }
+                    case 6: {
+                        internalFormat.push(addFeeTrade(tradeToAdd, trades[4], trades[5]));


Shouldnt there be a regular trade here?

Well, if you look at the data in the csv, the lines cancel themselves. Only the fee stays there. I’m not sure what it means

Ok I changed the code so that even if it cancels itself, it shows up as a trade. So we actually import the data.

starsoccer · 2022-12-14T14:55:21Z

src/parsers/trades/liquid/index.ts

+                    }
+                    case 8: {
+                        let secondTrade = tradeToAdd;
+                        internalFormat.push(addFeeTrade(tradeToAdd, trades[4], trades[5]));


I dont really get this what happens to trades 0 - 3

I don’t know why these trades over 6 or 8 lines exist but they all cancel themselves. Maybe a cancelled order or something

I’ll send a request to Liquid support to check

In the meantime, I changed the code so that even if it cancels itself, it shows up as a trade. So we actually import the data.

starsoccer · 2022-12-14T14:55:52Z

src/parsers/trades/liquid/index.ts

+    tradeToAdd.boughtCurrency = 'USDT';
+    tradeToAdd.soldCurrency = feeTrade.currency;
+    tradeToAdd.amountSold = amount;
+    tradeToAdd.rate = amount / 0;


Why are we dividing by zero here?

I’m paying fee but not receiving anything for that

I guess if we add tradeFee and tradeFeeCurrency, that would help. I’ll make a commit

Ok so I replaced this with a trade of amount 0, rate 1, and it has a fee that is the actual amount that is paid.

starsoccer · 2022-12-14T14:56:39Z

In case you want to check the data CryptoTransactions.csv

I cant seem to open this file either

Zahrun · 2022-12-14T15:03:33Z

In case you want to check the data CryptoTransactions.csv

I cant seem to open this file either

Seems fine to me, downloaded from the same link

starsoccer · 2022-12-14T15:09:57Z

In case you want to check the data CryptoTransactions.csv

I cant seem to open this file either

Seems fine to me, downloaded from the same link

Is this a CSV or something else?

Zahrun · 2022-12-14T15:11:18Z

In case you want to check the data CryptoTransactions.csv

I cant seem to open this file either

Seems fine to me, downloaded from the same link

Is this a CSV or something else?

Simple UTF-8 csv

Zahrun · 2022-12-15T16:02:56Z

So there are two files in the statements, one for Crypto and one for Fiat. I changed the import process so that it can manage the two different header hashes and also it asks for a second file. Please try these files:
CryptoTransactions.csv
FiatTransactions.csv

vercel bot had a problem deploying to Preview December 13, 2022 11:25 Failure

starsoccer reviewed Dec 13, 2022

View reviewed changes

src/parsers/trades/liquid/index.ts Outdated Show resolved Hide resolved

starsoccer reviewed Dec 13, 2022

View reviewed changes

src/types/locations.ts Outdated Show resolved Hide resolved

Zahrun force-pushed the liquid branch from 09bcb6b to fd89855 Compare December 13, 2022 17:19

vercel bot had a problem deploying to Preview December 13, 2022 17:19 Failure

Zahrun force-pushed the liquid branch from fd89855 to 0676dd3 Compare December 14, 2022 00:37

vercel bot had a problem deploying to Preview December 14, 2022 00:37 Failure

Zahrun force-pushed the liquid branch from 0676dd3 to cdcb3d9 Compare December 14, 2022 00:50

vercel bot had a problem deploying to Preview December 14, 2022 00:50 Failure

Zahrun force-pushed the liquid branch from cdcb3d9 to ebf9368 Compare December 14, 2022 00:53

vercel bot had a problem deploying to Preview December 14, 2022 00:53 Failure

starsoccer reviewed Dec 14, 2022

View reviewed changes

src/parsers/trades/liquid/index.ts Show resolved Hide resolved

starsoccer reviewed Dec 14, 2022

View reviewed changes

vercel bot had a problem deploying to Preview December 14, 2022 15:13 Failure

Zahrun added 3 commits December 14, 2022 16:13

feat: support liquid trades import

8d9d25c

feat: support liquid trades import

4de086d

fix: define types

27e6459

Zahrun force-pushed the liquid branch from e53f5c7 to 27e6459 Compare December 14, 2022 15:14

fix: better for loop

412cc91

vercel bot had a problem deploying to Preview December 15, 2022 11:09 Failure

feat: better support liquid trades import

d5f848e

vercel bot had a problem deploying to Preview December 15, 2022 15:56 Failure

Zahrun mentioned this pull request Dec 15, 2022

feat: support gate.io trades import #279

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support liquid trades import #281

feat: support liquid trades import #281

Zahrun commented Dec 13, 2022

vercel bot commented Dec 13, 2022 •

edited

Loading

starsoccer Dec 13, 2022

Zahrun Dec 13, 2022

starsoccer Dec 14, 2022

Zahrun Dec 14, 2022

starsoccer Dec 13, 2022

Zahrun Dec 13, 2022

Zahrun Dec 14, 2022

Zahrun commented Dec 14, 2022

starsoccer Dec 14, 2022

Zahrun Dec 14, 2022

Zahrun Dec 14, 2022

starsoccer Dec 14, 2022

Zahrun Dec 15, 2022

starsoccer Dec 14, 2022

Zahrun Dec 14, 2022

Zahrun Dec 15, 2022

starsoccer Dec 14, 2022

Zahrun Dec 14, 2022

Zahrun Dec 14, 2022

Zahrun Dec 15, 2022

Zahrun Dec 15, 2022

starsoccer Dec 14, 2022

Zahrun Dec 14, 2022

Zahrun Dec 15, 2022

Zahrun Dec 15, 2022

starsoccer commented Dec 14, 2022

Zahrun commented Dec 14, 2022

starsoccer commented Dec 14, 2022

Zahrun commented Dec 14, 2022

Zahrun commented Dec 15, 2022

feat: support liquid trades import #281

Are you sure you want to change the base?

feat: support liquid trades import #281

Conversation

Zahrun commented Dec 13, 2022

vercel bot commented Dec 13, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zahrun commented Dec 14, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

starsoccer commented Dec 14, 2022

Zahrun commented Dec 14, 2022

starsoccer commented Dec 14, 2022

Zahrun commented Dec 14, 2022

Zahrun commented Dec 15, 2022

vercel bot commented Dec 13, 2022 •

edited

Loading