-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bool ops and change biguint supported types #150
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @anatgstarkware, @DavidLevitGurevich, and @ohad-starkware)
stwo_cairo_prover/crates/prover_types/src/cpu.rs
line 614 at r1 (raw file):
6 => "BigUInt<384, 6>".to_string(), 7 => "BigUInt<448, 7>".to_string(), 12 => "BigUInt<768, 12>".to_string(),
Don't we need 4,8 anymore?
Also, can we just format the expression x -> <64*x, x>?
Code quote:
6 => "BigUInt<384, 6>".to_string(),
7 => "BigUInt<448, 7>".to_string(),
12 => "BigUInt<768, 12>".to_string(),
Previously, shaharsamocha7 wrote…
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @anatgstarkware, @DavidLevitGurevich, and @ohad-starkware)
stwo_cairo_prover/crates/prover_types/src/cpu.rs
line 614 at r1 (raw file):
Previously, anatgstarkware (anatg) wrote…
- We don't need 4 & 8
- AFAIK there's no way to do that in rust
1fea24f
to
83457a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @DavidLevitGurevich, @ohad-starkware, and @shaharsamocha7)
stwo_cairo_prover/crates/prover_types/src/cpu.rs
line 614 at r1 (raw file):
Previously, shaharsamocha7 wrote…
ahhh, done, thanks
This change is