Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bool ops and change biguint supported types #150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anatgstarkware
Copy link

@anatgstarkware anatgstarkware commented Oct 31, 2024

This change is Reviewable

Copy link
Contributor

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @anatgstarkware, @DavidLevitGurevich, and @ohad-starkware)


stwo_cairo_prover/crates/prover_types/src/cpu.rs line 614 at r1 (raw file):

            6 => "BigUInt<384, 6>".to_string(),
            7 => "BigUInt<448, 7>".to_string(),
            12 => "BigUInt<768, 12>".to_string(),

Don't we need 4,8 anymore?
Also, can we just format the expression x -> <64*x, x>?

Code quote:

            6 => "BigUInt<384, 6>".to_string(),
            7 => "BigUInt<448, 7>".to_string(),
            12 => "BigUInt<768, 12>".to_string(),

@anatgstarkware
Copy link
Author

stwo_cairo_prover/crates/prover_types/src/cpu.rs line 614 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Don't we need 4,8 anymore?
Also, can we just format the expression x -> <64*x, x>?

  • We don't need 4 & 8
  • AFAIK there's no way to do that in rust

Copy link
Contributor

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @anatgstarkware, @DavidLevitGurevich, and @ohad-starkware)


stwo_cairo_prover/crates/prover_types/src/cpu.rs line 614 at r1 (raw file):

Previously, anatgstarkware (anatg) wrote…
  • We don't need 4 & 8
  • AFAIK there's no way to do that in rust

https://doc.rust-lang.org/std/fmt/

Copy link
Author

@anatgstarkware anatgstarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @DavidLevitGurevich, @ohad-starkware, and @shaharsamocha7)


stwo_cairo_prover/crates/prover_types/src/cpu.rs line 614 at r1 (raw file):

Previously, shaharsamocha7 wrote…

https://doc.rust-lang.org/std/fmt/

ahhh, done, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants