Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto expand rangecheck evals #145

Merged
merged 1 commit into from
Oct 30, 2024
Merged

auto expand rangecheck evals #145

merged 1 commit into from
Oct 30, 2024

Conversation

ohad-starkware
Copy link
Contributor

@ohad-starkware ohad-starkware commented Oct 29, 2024 •
edited
Loading

This change is Reviewable

@ohad-starkware Graphite App
Copy link
Contributor Author

ohad-starkware commented Oct 29, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ohad-starkware and the rest of your teammates on Graphite Graphite

@ohad-starkware ohad-starkware mentioned this pull request Oct 29, 2024
Merged
@ohad-starkware ohad-starkware self-assigned this Oct 29, 2024
@ohad-starkware ohad-starkware force-pushed the ohad/rangecheck_vectory_in_memory branch 2 times, most recently from 6f87335 to d0ce7ac Compare October 30, 2024 11:38
@ohad-starkware ohad-starkware force-pushed the ohad/rangecheck_macro branch 2 times, most recently from 14e9299 to 0f964e3 Compare October 30, 2024 11:43
@ilyalesokhin-starkware
Copy link
Collaborator

stwo_cairo_prover/crates/prover/Cargo.toml line 18 at r2 (raw file):

thiserror.workspace = true
tracing.workspace = true
paste = "1.0"

Why not in the workspace?

Code quote:

paste = "1.0"

ilyalesokhin-starkware
ilyalesokhin-starkware reviewed Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 8 files at r1.
Reviewable status: 1 of 8 files reviewed, 1 unresolved discussion (waiting on @ohad-starkware)

ohad-starkware
ohad-starkware commented Oct 30, 2024
View reviewed changes
Copy link
Contributor Author

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 8 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware and @ohad-starkware)

stwo_cairo_prover/crates/prover/Cargo.toml line 18 at r2 (raw file):

Previously, ilyalesokhin-starkware wrote…

Why not in the workspace?

moved to workspace

ilyalesokhin-starkware
ilyalesokhin-starkware approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 8 files at r1, 1 of 2 files at r2, 4 of 4 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)

@ohad-starkware Graphite App
Copy link
Contributor Author

ohad-starkware commented Oct 30, 2024 •
edited
Loading

Merge activity

  • Oct 30, 8:12 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 30, 8:14 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 30, 8:16 AM EDT: A user merged this pull request with Graphite.

@ohad-starkware ohad-starkware changed the base branch from ohad/rangecheck_vectory_in_memory to graphite-base/145 October 30, 2024 12:12
@ohad-starkware ohad-starkware changed the base branch from graphite-base/145 to main October 30, 2024 12:12
@ohad-starkware ohad-starkware merged commit fe197ff into main Oct 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyalesokhin-starkware ilyalesokhin-starkware ilyalesokhin-starkware approved these changes

Assignees

@ohad-starkware ohad-starkware

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ohad-starkware @ilyalesokhin-starkware