Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fee): block context creator may fail #507

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Aug 19, 2024

This change is Reviewable

@nimrod-starkware nimrod-starkware marked this pull request as ready for review August 19, 2024 10:49
@nimrod-starkware nimrod-starkware self-assigned this Aug 19, 2024
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from d89e3fd to 4668bc1 Compare August 19, 2024 11:15
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/block_context_creator branch from 3f4a277 to d772755 Compare August 19, 2024 11:15
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from 4668bc1 to a9bca83 Compare August 19, 2024 11:43
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/block_context_creator branch from d772755 to 5c10c7b Compare August 19, 2024 11:43
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from a9bca83 to 0edc05f Compare August 19, 2024 11:55
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/block_context_creator branch from 5c10c7b to cbb4e6a Compare August 19, 2024 11:55
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from 0edc05f to 162f6e2 Compare August 19, 2024 12:39
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/block_context_creator branch from cbb4e6a to c9aa976 Compare August 19, 2024 12:39
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from 162f6e2 to 61d58fd Compare August 19, 2024 13:16
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/block_context_creator branch from c9aa976 to ad9d50c Compare August 19, 2024 13:16
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from 61d58fd to 3fafce9 Compare August 20, 2024 08:38
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/block_context_creator branch from ad9d50c to 72bc281 Compare August 20, 2024 08:39
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from 3fafce9 to b6769b7 Compare August 20, 2024 08:52
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/block_context_creator branch from 72bc281 to cdb9892 Compare August 20, 2024 08:52
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from b6769b7 to dc03a97 Compare August 20, 2024 10:11
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/block_context_creator branch from cdb9892 to 0397362 Compare August 20, 2024 10:11
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from dc03a97 to 57766e2 Compare August 20, 2024 10:36
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from 0d6e837 to f728fc1 Compare August 25, 2024 12:32
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/block_context_creator branch from 1802aaa to c9e4d63 Compare August 25, 2024 12:32
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.58%. Comparing base (676c4a4) to head (10d32c9).
Report is 2 commits behind head on main.

Files Patch % Lines
...es/blockifier/src/blockifier/stateful_validator.rs 0.00% 0 Missing and 2 partials ⚠️
...lockifier/src/transaction/transaction_execution.rs 0.00% 0 Missing and 2 partials ⚠️
crates/blockifier/src/context.rs 66.66% 0 Missing and 1 partial ⚠️
.../blockifier/src/transaction/account_transaction.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
- Coverage   76.63%   76.58%   -0.05%     
==========================================
  Files         351      351              
  Lines       37092    37093       +1     
  Branches    37092    37093       +1     
==========================================
- Hits        28424    28408      -16     
- Misses       6369     6374       +5     
- Partials     2299     2311      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from f728fc1 to 669b111 Compare August 26, 2024 08:11
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/block_context_creator branch from c9e4d63 to 1c1afcd Compare August 26, 2024 08:11
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r8, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from 669b111 to 8b53820 Compare August 26, 2024 13:11
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/block_context_creator branch from 1c1afcd to 18eb487 Compare August 26, 2024 13:11
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from 8b53820 to 18bf0a3 Compare August 27, 2024 07:24
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/block_context_creator branch from 18eb487 to 19c7557 Compare August 27, 2024 07:24
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r9, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

Copy link
Contributor Author

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python side

Reviewable status: 12 of 13 files reviewed, all discussions resolved (waiting on @dorimedini-starkware and @TzahiTaub)

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r10, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

Copy link
Contributor Author

nimrod-starkware commented Aug 28, 2024

Merge activity

@nimrod-starkware nimrod-starkware changed the base branch from nimrod/resources_enum/tx_info_creator to graphite-base/507 August 28, 2024 13:45
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@nimrod-starkware nimrod-starkware changed the base branch from graphite-base/507 to main August 28, 2024 13:57
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/block_context_creator branch from a21e7a7 to 10d32c9 Compare August 28, 2024 13:59
@nimrod-starkware nimrod-starkware merged commit 2b7f89e into main Aug 28, 2024
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants