chore(blockifier): add pre_process_and_create c-tor for TransactionEx…

[Yoni-Starkware]

…ecutor

---

This change is 

[codecov]

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.30%. Comparing base (b0cfe82) to head (2dd3cb9).
Report is 108 commits behind head on main.

Files with missing lines	Patch %	Lines
.../blockifier/src/blockifier/transaction_executor.rs	93.75%	0 Missing and 1 partial ⚠️
crates/blockifier/src/test_utils/struct_impls.rs	88.88%	1 Missing ⚠️
crates/native_blockifier/src/py_block_executor.rs	80.00%	0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (2dd3cb9). Click for more details.

HEAD has 2 uploads less than BASE

Flag	BASE (b0cfe82)	HEAD (2dd3cb9)
	3	1

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1030       +/-   ##
===========================================
- Coverage   74.18%   62.30%   -11.89%     
===========================================
  Files         359      146      -213     
  Lines       36240    17845    -18395     
  Branches    36240    17845    -18395     
===========================================
- Hits        26886    11118    -15768     
+ Misses       7220     5876     -1344     
+ Partials     2134      851     -1283     

Flag	Coverage Δ
	62.30% <90.00%> (-11.89%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Yael-Starkware]

Reviewed 3 of 5 files at r1.
Reviewable status: 3 of 5 files reviewed, 2 unresolved discussions (waiting on @noaov1 and @Yoni-Starkware)

---

crates/blockifier/src/test_utils/struct_impls.rs line 145 at r1 (raw file):

impl BlockNumberHashPair {
    pub fn create_given_current(block_number: BlockNumber) -> Option<Self> {

I think that the name is misleading

Suggestion:

create_dummy_given_current

---

crates/native_blockifier/src/py_block_executor.rs line 143 at r1 (raw file):

        Ok(())
    }

I would expect papyrus_execution to use pre_process_and_create as well, but I see that they are using a completely different object there for execution. why?

[Yoni-Starkware]

Reviewable status: 1 of 6 files reviewed, 2 unresolved discussions (waiting on @noaov1 and @Yael-Starkware)

---

crates/blockifier/src/test_utils/struct_impls.rs line 145 at r1 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

I think that the name is misleading

Done.

---

crates/native_blockifier/src/py_block_executor.rs line 143 at r1 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

I would expect papyrus_execution to use pre_process_and_create as well, but I see that they are using a completely different object there for execution. why?

Hmmm, I think that they need more things (e.g. state diff per tx) which is not supported atm.
Added a TODO

[Yael-Starkware]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: 4 of 6 files reviewed, all discussions resolved (waiting on @noaov1)

[Yoni-Starkware]

Reviewed 1 of 5 files at r1, 1 of 3 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)