Merge pull request #6 from stanwood/feature/SFW-295-improve-viewmodel…

…-handling SFW-295 Fix dagger always returning the same view model instance, ret…
stanwood · Dec 5, 2018 · 4a21199 · 4a21199
2 parents 4d91ca9 + 353a3e5
commit 4a21199
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/di/README.md b/di/README.md
@@ -132,7 +132,6 @@ class HomeFragment : Fragment(), HasSupportFragmentInjector {
 There is not much to do for ViewModels except for adding a constructor annotated with `@Inject`:
 
 ```kotlin
-@FragmentScope
 class HomeViewModel @Inject constructor(/* inject properties here if you want */) : ViewModel() {}
 ```
 

diff --git a/di/src/main/java/io/stanwood/framework/arch/di/factory/ViewModelFactory.kt b/di/src/main/java/io/stanwood/framework/arch/di/factory/ViewModelFactory.kt
@@ -23,11 +23,11 @@ package io.stanwood.framework.arch.di.factory
 
 import androidx.lifecycle.ViewModel
 import androidx.lifecycle.ViewModelProvider
-import dagger.Lazy
 import javax.inject.Inject
+import javax.inject.Provider
 
 class ViewModelFactory<T : ViewModel> @Inject constructor(
-    private val viewModel: Lazy<T>
+    private val viewModel: Provider<T>
 ) : ViewModelProvider.Factory {
     @Suppress("UNCHECKED_CAST")
     override fun <T : ViewModel?> create(modelClass: Class<T>): T = viewModel.get() as T