Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate improvements from @soshial/@tripplet + myself #151

Closed
wants to merge 28 commits into from

Conversation

ndoo
Copy link

@ndoo ndoo commented Jan 12, 2022

Merged a bunch of improvements/fixes from soshial@, and cherry-picked improvements/fixes from tripplet. Added some improvements of my own. Please refer to commits for specifics. Review/feedback welcome.

Duplicates:

Apologies for raising a large PR, but hopefully I was able to add some value, as I have compile-tested and fuctionality-tested the changes on my Freematics ONE+ model B.

soshial and others added 28 commits June 6, 2021 15:43
elaborate differences between protocols
Copy link

@SpaceCat101 SpaceCat101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So after changing the volume and frequency (Freematics.cpp), how can I customize it? It sounds the same to me.

@ndoo
Copy link
Author

ndoo commented Mar 29, 2022

So after changing the volume and frequency (Freematics.cpp), how can I customize it? It sounds the same to me.

Hi there, this is implemented in 51c2548 - telelogger v5: Add customizable startup beep sequence:

The configuration needed is documented in config.h:

#define BEEP_TABLE {2000} /* Hz, each value is a 100ms cycle (use "0" to add gaps) */

E.g.:

#define BEEP_TABLE {1000, 0, 2000, 0, 4000} /* Hz, each value is a 100ms cycle (use "0" to add gaps) */

Copy link

@SpaceCat101 SpaceCat101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
With this code how are we suppose to control the buzzer? Is the original volume the loudest already?

@ndoo
Copy link
Author

ndoo commented Apr 11, 2022

Hi, With this code how are we suppose to control the buzzer? Is the original volume the loudest already?

Hi, volume control is out of scope of this PR. The original volume is the loudest possible already.

@SpaceCat101
Copy link

Hi,
Do you have any clue how I can adjust the volume of the buzzer?

@ndoo ndoo closed this Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants