Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SerperRM Bug] #236

Merged
merged 2 commits into from
Oct 27, 2024
Merged

[SerperRM Bug] #236

merged 2 commits into from
Oct 27, 2024

Conversation

zhoucheng89
Copy link
Contributor

valid_url_to_snippets.get(url, {}) get none value. call strip function will be fix it. just like url.strip("'")

valid_url_to_snippets.get(url, {}) get none value.
call strip function will be fix it. just like url.strip("\'")
@shaoyijia
Copy link
Collaborator

Hi @zhoucheng89 , it seems like the format check fails so I cannot merge this due to our repository rule. Could you run the following:

pip install black
black knowledge_storm

Thanks!

valid_url_to_snippets.get(url, {}) get none value.
call strip function will be fix it. just like url.strip("\'").
format code and commit.
@zhoucheng89
Copy link
Contributor Author

@shaoyijia Thank you for your reminder. I have formatted the code as you suggested. Please confirm again. Thanks!

Copy link
Collaborator

@shaoyijia shaoyijia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@shaoyijia shaoyijia merged commit dcfa2bd into stanford-oval:main Oct 27, 2024
1 check passed
@zhoucheng89
Copy link
Contributor Author

@shaoyijia Can you merge this commit into the dev-Chinese branch? As I am debugging this branch, it requires synchronized and fixed code

@shaoyijia
Copy link
Collaborator

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants