Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Costorm integration #185

Merged
merged 19 commits into from
Sep 25, 2024
Merged

Costorm integration #185

merged 19 commits into from
Sep 25, 2024

Conversation

Yucheng-Jiang
Copy link
Collaborator

@Yucheng-Jiang Yucheng-Jiang commented Sep 25, 2024

Tasks

  • Integrate Co-STORM code to knowledge_storm (without experiment code, example, evaluation, and data)
  • Sync interface changes including unifying information and retriever datatype between STORM and Co-STORM, add dataclass, refactor encoder as an interface, define logging wrapper (not used in STORM pipeline yet)
  • Apply patches to STORM pipeline to make it more robust and compatible with more LMs.
  • Bump up version
  • Update main branch README (with costorm information, update announcement, and add dataset section)
  • Include Co-STORM example

@Yucheng-Jiang Yucheng-Jiang changed the base branch from main to main-branch-cleanup September 25, 2024 04:47
Base automatically changed from main-branch-cleanup to main September 25, 2024 04:59
@shaoyijia
Copy link
Collaborator

is this one ready?

@Yucheng-Jiang
Copy link
Collaborator Author

is this one ready?

I'm updating README and Co-STORM example notebook. Other parts are ready.

Copy link
Collaborator

@shaoyijia shaoyijia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing amazing efforts!!! Thank you!!!

knowledge_storm/collaborative_storm/engine.py Show resolved Hide resolved
knowledge_storm/collaborative_storm/engine.py Show resolved Hide resolved
knowledge_storm/collaborative_storm/engine.py Show resolved Hide resolved
knowledge_storm/collaborative_storm/engine.py Outdated Show resolved Hide resolved
knowledge_storm/collaborative_storm/engine.py Show resolved Hide resolved
knowledge_storm/dataclass.py Show resolved Hide resolved
knowledge_storm/interface.py Show resolved Hide resolved
knowledge_storm/rm.py Show resolved Hide resolved
knowledge_storm/rm.py Outdated Show resolved Hide resolved
@Yucheng-Jiang
Copy link
Collaborator Author

Thanks for the comments! Resolving them now

@Yucheng-Jiang
Copy link
Collaborator Author

@shaoyijia Resolved comments, update README, and add co-storm example.

shaoyijia
shaoyijia previously approved these changes Sep 25, 2024
Copy link
Collaborator

@shaoyijia shaoyijia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to go now.

@Yucheng-Jiang Yucheng-Jiang merged commit 564a507 into main Sep 25, 2024
1 check passed
Copy link

@SHAUKYY SHAUKYY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants