Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New RM] Add GoogleSearch #183

Merged
merged 2 commits into from
Sep 25, 2024
Merged

[New RM] Add GoogleSearch #183

merged 2 commits into from
Sep 25, 2024

Conversation

shaoyijia
Copy link
Collaborator

See the title.

Yucheng-Jiang
Yucheng-Jiang approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@Yucheng-Jiang Yucheng-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shaoyijia
Copy link
Collaborator Author

Thanks!! this PR is just an enhancement so that I can use GoogleSearch. Ping you because I don't want to accidentally introduce conflict to your current effort.

@shaoyijia shaoyijia merged commit 3328c97 into main Sep 25, 2024
1 check passed
@shaoyijia shaoyijia deleted the dev-google-search branch September 25, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yucheng-Jiang Yucheng-Jiang Yucheng-Jiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaoyijia @Yucheng-Jiang