-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle perturbations in run predictions frontend #2950
Conversation
helm-frontend/src/routes/Run.tsx
Outdated
@@ -45,10 +45,10 @@ export default function Run() { | |||
const [instances, setInstances] = useState<Instance[]>([]); | |||
const [stats, setStats] = useState<Stat[]>([]); | |||
const [displayPredictionsMap, setDisplayPredictionsMap] = useState< | |||
DisplayPredictionsMap | undefined | |||
undefined | { [key: string]: { [key: string]: DisplayPrediction[] } } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: undefined | Record<string, Record<string, DisplayPrediction[]>>
is a little cleaner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
helm-frontend/src/routes/Run.tsx
Outdated
>(); | ||
const [displayRequestsMap, setDisplayRequestsMap] = useState< | ||
DisplayRequestsMap | undefined | ||
undefined | { [key: string]: { [key: string]: DisplayRequest[] } } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as above about Record
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Fixes #2940
Frontend now displays perturbations like so: