Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with JSON and LaTeX #1873

Merged
merged 7 commits into from
Oct 6, 2023
Merged

Conversation

farzaank
Copy link
Contributor

@farzaank farzaank commented Oct 3, 2023

This should fix the link issue.

My formatter added some unnecessary changes too, not sure what I should do regarding that.

Fixes #1591
Fixes #1702

@farzaank farzaank requested a review from yifanmai October 3, 2023 18:48
@farzaank farzaank changed the title Fix Fix issue with JSON and LaTeX Oct 3, 2023
Copy link
Collaborator

@yifanmai yifanmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split this into two PRs, one for just the lint and one for just the changes?

src/helm/benchmark/static/benchmarking.js Outdated Show resolved Hide resolved
@farzaank farzaank mentioned this pull request Oct 5, 2023
@farzaank farzaank requested a review from yifanmai October 6, 2023 20:02
Copy link
Collaborator

@yifanmai yifanmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yifanmai yifanmai merged commit 175a635 into main Oct 6, 2023
2 of 3 checks passed
@yifanmai yifanmai deleted the farzaan/fix-latex-json-link-bug branch October 6, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite JSON / LaTeX / code URLs in frontend LaTeX links are dead in website
2 participants