Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor docs improvements on new scenario and credentials.conf #1780

Merged
merged 6 commits into from
Aug 14, 2023
Merged

Minor docs improvements on new scenario and credentials.conf #1780

merged 6 commits into from
Aug 14, 2023

Conversation

unnawut
Copy link
Contributor

@unnawut unnawut commented Aug 12, 2023

Tried to create a new scenario and spotted a few points in the docs that would have saved me some time:

  1. Prepended path to the right __init__.py file
  2. Added instruction to add schema for the new scenario
  3. Minor formatting fix in the metrics section that's preventing the bullet rendering
  4. Add proper template for credentials.conf

yifanmai
yifanmai approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@yifanmai yifanmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@yifanmai yifanmai merged commit 5f9794c into stanford-crfm:main Aug 14, 2023
3 checks passed
danielz02 pushed a commit to danielz02/helm that referenced this pull request Sep 7, 2023
@unnawut @danielz02
Minor docs improvements on new scenario and credentials.conf (stanfor…
2464d4b 
…d-crfm#1780)
danielz02 pushed a commit to danielz02/helm that referenced this pull request Sep 7, 2023
@unnawut @danielz02
Minor docs improvements on new scenario and credentials.conf (stanfor…
2d324d0 
…d-crfm#1780)
danielz02 pushed a commit to danielz02/helm that referenced this pull request Sep 7, 2023
@unnawut @danielz02
Minor docs improvements on new scenario and credentials.conf (stanfor…
7c3ae2d 
…d-crfm#1780)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yifanmai yifanmai yifanmai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unnawut @yifanmai