Set output-ngrams to default to true and update README #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
percyliang
reviewed
Aug 10, 2023
| @@ -13,7 +13,7 @@ def get_data_overlap_args() -> Any: | |||
| required=True, | |||
| help="The format of your input file for your training data, e.g. raw, custom, the_pile", | |||
| ) | |||
| parser.add_argument("--output-ngrams", type=bool, default=False, help="Whether to output ngrams") | |||
| parser.add_argument("--output-ngrams", type=bool, default=True, help="Whether to output ngrams") | |||
There was a problem hiding this comment.
If you set the default to True, there's no way to turn it off, right?
There was a problem hiding this comment.
Thanks for the catch, I've updated it to be --no-output-ngrams which can be passed to not output ngrams.
added 3 commits
August 9, 2023 18:35
percyliang
reviewed
Aug 10, 2023
scripts/data_overlap/README.md
Outdated
| @@ -24,14 +24,15 @@ This needs to be run from the data overlap directory; i.e. cd scripts/data_overl | |||
|
|
|||
| Usage: | |||
|
|
|||
| python [compute_data_overlap_metrics.py OR run_data_overlap_beam.py] --input-data <input_data> --scenario-data <scenario_data> --output-stats <output_stats> --input-format <input_format> | |||
| python [compute_data_overlap_metrics.py OR run_data_overlap_beam.py] --input-data <input_data> --scenario-data <scenario_data> --output-stats <output_stats> --input-format <input_format> | |||
There was a problem hiding this comment.
Deleted, thanks
percyliang
approved these changes
Aug 10, 2023
yifanmai
approved these changes
Aug 11, 2023
danielz02
pushed a commit
to danielz02/helm
that referenced
this pull request
Sep 7, 2023
…#1776) Co-authored-by: Andy Z <[email protected]>
danielz02
pushed a commit
to danielz02/helm
that referenced
this pull request
Sep 7, 2023
…#1776) Co-authored-by: Andy Z <[email protected]>
danielz02
pushed a commit
to danielz02/helm
that referenced
this pull request
Sep 7, 2023
…#1776) Co-authored-by: Andy Z <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.