Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port and Test work #55

Merged
merged 2 commits into from
Feb 11, 2024
Merged

Port and Test work #55

merged 2 commits into from
Feb 11, 2024

Commits on Feb 11, 2024

  1. chore(cspp): Set up running tests via Makefile

    Michael Stahnke committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    7bb8b8e View commit details
    Browse the repository at this point in the history

  2. fix(cspp): Fix PORT and BASE_URL behavior 

    Originally, if `CSPP_PORT` and the port found in `CSPP_BASE_URL` weren't the
same, it would service on `CSPP_PORT` but link out and log with
`CSPP_BASE_URL`. THis was bad. To fix this, we now honor the port found in
`CSPP_BASE_URL` at all times, unless it's not set (e.g. it's just a string like
`http://example.com/cspp`) and `CSPP_PORT` is set. Then it will use `CSPP_PORT`
for all things. If neither is specified, it's just port 8080.
    Michael Stahnke committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    44afcba View commit details
    Browse the repository at this point in the history