Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggregation Extension #684
Aggregation Extension #684
Changes from 5 commits
adc11f8
b2f0348
9b993e7
52177c5
32883fa
89bfd15
681200c
ce4ddfa
fe297df
da6cd5a
bef27d2
8e79864
0c18845
524d25f
2a4a936
10ad880
8720906
0c6ed7f
9ed0d37
7a75478
7c92f11
436be4c
0bcb41a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can
filter
be included in this? I'm not sure how the extensions interact.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I have tested with filter included on an implementation and it works great.
I am also not clear on how extension interact. For instance, could
collections
,datetime
,bbox
, andintersects
be excluded here since they are part of the core search? I'm inclined to keep so the request class correlates directly to the extension spec.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, i think you should extend BaseSearchGetRequest and BaseSearchPostRequest and just add the
aggregations
param. You also pickuplimit
that's ignored, but that's find for a datamodel like this since there's a lot less duplicationThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed it to be build off base Search and Filter. This makes the implementation dependent on the Filter extension. But I don't think that is an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesfisher-gis sorry I'm just realizing this now but I don't think we should do this, at least I don't see in the
aggregate
extension why thefilter
attributes should be enabled with theaggregations
ones.I think it will be up to the implementers to add the
filter
extension and also handle them in the client.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey. That makes sense.
I have a couple other small bug fixes for aggregation. I will submit a PR today that removes the Filter extension dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe wait because I will submit a PR that takes care of #713 soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesfisher-gis in fact, go ahead because my PR is a no-go in fact 😓