Enable search on /items and add queryables links #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
approved these changes
Aug 1, 2024
|
@m-mohr this is ready to be merged. Let me know if the changed I have made are 👍 |
|
I think it looks good, but disclaimer: I'm not overly deep into stac-fastapi. |
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
We had issues getting per-collection item search to work. Also, the queryables links were missing. Here's how we solved it. There might be better solutions, but maybe it helps someone until a proper solution is in place (there are some PRs in place that try to do similar things, e.g. stac-utils/stac-fastapi#587 and #49)
PR Checklist:
pre-commithooks pass locallymake test)make docs)