Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove entropy in tests #507

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove entropy in tests #507

wants to merge 2 commits into from

Conversation

MatheusFranco99
Copy link
Contributor

@MatheusFranco99 MatheusFranco99 commented Sep 25, 2024 •
edited
Loading

Overview

This PR removes the entropy that exists in types tests. The two changes were:

  • for SignedSSVMessageTest test, we simply started using a constant key.
  • for the more complicated EncryptionSpecTest test, we had to change the test structure. We removed the CypherText field, which inevitably has entropy, and used constant keys, instead of generating new ones.

Closes #308

@MatheusFranco99 MatheusFranco99 self-assigned this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GalRogozinski GalRogozinski Awaiting requested review from GalRogozinski

At least 3 approving reviews are required to merge this pull request.

Assignees

@MatheusFranco99 MatheusFranco99

Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop creating random keys that change generated tests.json
1 participant
@MatheusFranco99