Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR makes the
Committee
structure the entry point in theSSV
module.Before, we had both
Committee
andValidator
as distinct entry points. Now,Committee
holdsValidator
objects and redirects messages and duty-start events to the appropriate validator object.Extra changes
As refactoring, this PR also:
Validator
structureProcessMessage
function existent inCommittee
andValidator
to a unique one to avoid duplicated knowledgeAdded tests
Note
For the test case of a message with
MessageID
that doesn't belong to either the committee or to a validator, we already had theWrongMessageID
test. Thus, we simply aligned the error string.Closes #451