Better error handling for 'Peers' metric in all groups #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaclav-ssvlabs
approved these changes
Oct 2, 2024
oleg-ssvlabs
force-pushed
the
peers-errors-handling
branch
from
a194d9e
to
f9b83e7
Compare
zktaiga
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
In some scenarios, we encountered error responses in the “Peers” metric, but the error logs did not specify the issue. There were two problems:
This implementation addresses the issue and improves the handling of such errors.
Other:
I know the code is not very DRY, but my gut feeling tells me it’s too early for abstraction. In the long term, if we have more metrics with similar scenarios where we need to use the HTTP client extensively, we should build a custom HTTP client wrapper centrally and reuse it across all HTTP-based metrics.