Correctness sev

ssvlabs · Sep 2, 2024 · 3f470cd · 3f470cd
1 parent be4e486
commit 3f470cd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/internal/benchmark/metric.go b/internal/benchmark/metric.go
@@ -51,7 +51,10 @@ func LoadEnabledMetrics(config configs.Config) map[metric.Group][]metricService
 			configs.Values.Benchmark.Consensus.Address,
 			"Attestation",
 			network.GenesisTime[network.Name(config.Benchmark.Network)],
-			[]metric.HealthCondition[float64]{},
+			[]metric.HealthCondition[float64]{
+				{Name: consensus.CorrectnessMeasurement, Threshold: 97, Operator: metric.OperatorLessThanOrEqual, Severity: metric.SeverityHigh},
+				{Name: consensus.CorrectnessMeasurement, Threshold: 98.5, Operator: metric.OperatorLessThanOrEqual, Severity: metric.SeverityMedium},
+			},
 		))
 	}
 

diff --git a/internal/benchmark/metrics/consensus/attestation.go b/internal/benchmark/metrics/consensus/attestation.go
@@ -25,6 +25,7 @@ const (
 	ReceivedBlockMeasurement     = "ReceivedBlock"
 	MissedAttestationMeasurement = "MissedAttestation"
 	FreshAttestationMeasurement  = "FreshAttestation"
+	CorrectnessMeasurement       = "Correctness"
 )
 
 var (
@@ -158,14 +159,15 @@ func (a *AttestationMetric) fetchAttestationBlockRoot(ctx context.Context, slot
 }
 
 func (a *AttestationMetric) AggregateResults() string {
-	var missedAttestations, freshAttestations, missedBlocks, receivedBlocks, unreadyBlocks float64
+	var missedAttestations, freshAttestations, missedBlocks, receivedBlocks, unreadyBlocks, correctness float64
 
 	for _, point := range a.DataPoints {
 		missedAttestations += point.Values[MissedAttestationMeasurement]
 		missedBlocks += point.Values[MissedBlockMeasurement]
 		freshAttestations += point.Values[FreshAttestationMeasurement]
 		receivedBlocks += point.Values[ReceivedBlockMeasurement]
 		unreadyBlocks += point.Values[UnreadyBlockMeasurement]
+		correctness += freshAttestations / receivedBlocks * 100
 	}
 
 	return fmt.Sprintf(
@@ -175,7 +177,7 @@ func (a *AttestationMetric) AggregateResults() string {
 		missedBlocks,
 		freshAttestations,
 		receivedBlocks,
-		freshAttestations/receivedBlocks*100)
+		correctness)
 }
 
 func (a *AttestationMetric) calculateMeasurements(slot phase0.Slot) {