Update readme #19
Merged
Update readme #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Introduction Added Overview Standardized Initiator/Operator naming convention Refactored Flow description Moved Security Notes to the bottom Added Table of Contents
Added entire public keys Added explanation about operator info file
Added latest changes and parameters
Closed
...88a1d492e5f42ced7775fd755809eaec654defa379675ee820855c6582b8e1ed4943cc29a12d5fd45895a97.json
Outdated
Show resolved
Hide resolved
RaekwonIII
force-pushed
the
update-readme
branch
from
a10267e
to
068e2fd
Compare
y0sher
reviewed
Oct 18, 2023
y0sher
reviewed
Oct 18, 2023
y0sher
reviewed
Oct 18, 2023
y0sher
reviewed
Oct 18, 2023
y0sher
reviewed
Oct 18, 2023
y0sher
reviewed
Oct 18, 2023
y0sher
reviewed
Oct 18, 2023
y0sher
reviewed
Oct 18, 2023
y0sher
reviewed
Oct 18, 2023
y0sher
reviewed
Oct 18, 2023
README.md
Outdated
Comment on lines
171
to
173
| ## Architecture | ||
| ## Operator Quick start | ||
|
|
||
|  |
There was a problem hiding this comment.
maybe we should move flow and architecture to a different file. its worth to have a note about the arch and design for more advanced users. but its not a must in the readme.
There was a problem hiding this comment.
It is at the very end of the file. I do understand it's quite long, but since there's a table of content it's navigable at least.
If we want to move it to a different file, I am not opposed to that either.
y0sher
requested changes
Oct 18, 2023
RaekwonIII
commented
Oct 18, 2023
RaekwonIII
force-pushed
the
update-readme
branch
from
2c6de3b
to
3c15f18
Compare
y0sher
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-created branch with cherry-picked commits and made a few fixes on the final result.
Please disregard previous pull request.
@lior-blox @y0sher