Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

banner changed #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Spsingh0005
Copy link

@Spsingh0005 Spsingh0005 commented Jun 26, 2024

Pull Request Description

Fix: #15

Description
This pull request updates the hero banner to ensure compatibility across desktop, tablet, and mobile views. It includes adjustments to the layout and styling to enhance responsiveness.

Changes Made
Updated hero banner layout to be responsive across desktop, tablet, and mobile devices.
Incorporated adjustments to ensure consistent display and usability across different screen sizes.
Screenshots
Desktop View:
desktop view

Mobile View:
mob-view

Testing
Tested the hero banner on desktop, tablet, and mobile devices to confirm responsiveness and visual consistency.
Verified that the layout adapts correctly to different screen sizes without compromising functionality.

Notes for Reviewers
Please review the layout adjustments made to the hero banner to ensure compatibility across all specified devices.
The attached screenshots provide visual confirmation of the changes made for your assessment.

Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-e-commerce ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 11:57am

Copy link
Owner

@ssahibsingh ssahibsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Spsingh0005 website is not responsive for mobile device having width less than 440px. Try to resolve that by having a background without text over it and displaying text over the background using code only. As it is done earlier.

@ssahibsingh ssahibsingh linked an issue Aug 7, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change banner to make it more related
2 participants