Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gif for trim action #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hritikgupta
Copy link

No description provided.

@srbcheema1
Copy link
Owner

@hritikgupta just a small review. I saw the gif it is perfect according to the size and dimentions and content visibiility. just a thing. this tool is targetted for people who are not much familiar with computerscience field. it is kept simple. So the command that you ran to check the size of file, is easier to detect that it is size for those who know commanline. but for those who have weak background will get confused. just a small suggestion. you could do some commentry in the gif. commentry can be done by typing and erasing the sentences. like let us check the length of input file , len of input file comes out to be 2 mis 20 sec let us trim it from 0:00 to 1:00 let us check the final size of output file length of output file comes out to be 1 min 0 sec. hurray you got a trimmed video

Aslo there must be a pause of nothing at end of a gif coz it loops people should get time to know that it has restarted. you can also type END at end or any of other creative ways.

@srbcheema1
Copy link
Owner

srbcheema1 commented Oct 2, 2018

Also one more thing. your master seems to be outdated by now. there are some conflicts as I have updated the master. you may need to do some research to how to solve those conflicts.
Hints:

  • here it comes the need of branching,
  • but now you have worked on branch with name master you will have to continue with it else PR will close itself.
  • there are many ways to do so, pick any, brute force or real ways
  • brute force includes recloning the repo and then adding the file and pushing force fully.
  • smart method(difficult for now) will include fetching upstream and rebasing last commit over it.

I wont recommend smart method as per now. now you can continue with brute force or discover your own way by some googling. this will really be helpful for you in future.

A tip for future never ever make a PR from master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants