-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chathistory
Support
#619
Open
andymandias
wants to merge
8
commits into
main
Choose a base branch
from
feat/chathistory
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chathistory
Support
#619
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a57eff3
Initial refactoring of previous, unmerged `chathistory` implementation.
andymandias e623ccd
Simplify `FUZZ_SECONDS` and separate into distinct values for history…
andymandias 2535e69
Only consider text of message content for equality comparison.
andymandias cf4c67f
Rebase fixes.
andymandias 54f6bbe
Addressing review comments.
andymandias 3da7694
Rebase fixes.
andymandias 44d70ec
Fix for duplicate messages in history under certain circumstances.
andymandias a3bfce5
Restructure to move back-end related logic out of `main.rs` and to co…
andymandias File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't we have a commit which used a binary search implementation for inserting messages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is the
insert_message
from that work we did together, completely unchanged. I was lazy about persisting the commit history while refactoring, so it's all been squashed into one commit.The one thing this doesn't keep related to that work is the sorting of saved histories on load. In that version of the
chathistory
PR, I had changed the history storage scheme to no longer be obfuscated (no longer use hashes in naming the files). If histories were not found with the non-hashed storage scheme (where histories can be expected to be sorted already), then it would attempt to load & sort a history from the old, hashed storage scheme. I still like that idea, but it seemed like this PR might have too many changes already, so I omitted it this time around.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh my bad, I just totally forgot what the code looked like and didn't realize that was the implementation we landed on :P