Fix/scroll view #59
Merged
Fix/scroll view #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperstorm
approved these changes
Jun 27, 2023
High resolution trackpads like macos might send us multiple on_scroll messages between frames. Previous logic didn't account for this which would put scroll view into an invalid state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few issues related to scrollview:
Limit::Sincenot reliable for filtering since a specific message.Scrolling extremely fast on trackpad either from top of scrollable down or bottom up should be very reliable now.
@casperstorm can you confirm you can't break scrollable from either top or bottom (home / end) then scroll? I usually issue a
/listin server to ensure scrollable is huge and scroll like crazy.