Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom font #58

Merged
merged 4 commits into from
Jun 27, 2023
Merged

Allow custom font #58

merged 4 commits into from
Jun 27, 2023

Conversation

tarkah
Copy link
Member

@tarkah tarkah commented Jun 26, 2023

Resolves #26

Base automatically changed from feat/persist-layout to main June 26, 2023 22:15
Comment on lines +52 to +54
// DANGER ZONE - font must be set using config
// before we do any iced related stuff w/ it
font::set(config_load.as_ref().ok());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense!

pub struct Font {
pub family: Option<String>,
pub size: Option<u8>,
// TODO: Do we make size, etc configurable and pass to Theme?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops old comment

Copy link
Member

@casperstorm casperstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on both Windows and macOS. Works really well.

@tarkah tarkah merged commit 1eae22f into main Jun 27, 2023
1 check passed
@tarkah tarkah deleted the feat/custom-font branch June 27, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Custom Fonts in the App
2 participants