-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/theme editor #541
Merged
Merged
Feat/theme editor #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarkah
force-pushed
the
feat/theme-editor
branch
2 times, most recently
from
September 6, 2024 19:11
73859ea
to
71fe00d
Compare
casperstorm
approved these changes
Sep 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjust UI slightly and tested on macOS and Windows. Works perfectly.
This is SUCH a nice feature. Before we merge I'd like to add a entry to the book.
All good, @tarkah feel free to merge!
casperstorm
force-pushed
the
feat/theme-editor
branch
from
September 8, 2024 19:28
a8c177a
to
724a69a
Compare
Currently markdown formatting is borked for `_` emphasis since it `_` is also considered ascii punctutation so it was relaxing the open / close emphasis checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an in-app theme editor with the ability to save the theme and share it via a
halloy://
URL. Clicking those links will cause that theme to open in the theme editor, where users can subsequently save it.Oh yeah, adds multi window support to show theme editor 🚀 🚀 🚀 🚀 🚀 🚀
simplescreenrecorder-2024-09-06_11.24.00.mp4